Let activities heartbeat during worker shutdown#2903
Open
baekgyu-kim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
heartbeatExecutoralready shut down),HeartbeatContextImpl.heartbeat()now emits the heartbeat to the server before throwingActivityWorkerShutdownException(previously: thrown without sending).heartbeat()cannot flood the server.ActivityWorkerShutdownExceptionis always thrown, so a transient failure cannot mask the shutdown signal.ActivityWorkerShutdownExceptionJavadoc updated accordingly.Why?
heartbeat()threw immediately without contacting the server → no heartbeat during theawaitTerminationgrace period → server times the activity out and retries it → duplicate executions, despite the worker deliberately giving the activity time to finish.Checklist
Closes Add the ability to keep heartbeating while the worker is shutting down #2075
How was this tested:
New
HeartbeatContextImplTestcases:Any docs updates needed?
ActivityWorkerShutdownExceptionJavadoc.