Open
Conversation
sdk-core added protoc-gen-openapiv2 imports to cloud service protos.
This broke proto generation in two ways:
1. protoc couldn't resolve the import — none of the existing --proto_path
entries covered protoc-gen-openapiv2/. Added the protos/ root dir
as a --proto_path so protoc-gen-openapiv2/options/annotations.proto
is reachable.
2. The generated service_pb2.py requires the openapiv2 Python modules,
which didn't exist. Generated openapiv2 protos and move them into
temporalio/api/dependencies/protoc_gen_openapiv2/, with import
rewrites to match.
Also fixed the Docker proto generation (gen-protos-docker): google-adk
requires protobuf>=5 which conflicts with the protobuf<4 downgrade
needed for generation. Fix: remove google-adk before downgrading,
matching the CI workflow.
Mirrors sdk-dotnet#633.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Why?
Propagate envconfig fix in sdk-core to Python