Skip to content

fix: use workflow type name in WorkflowAlreadyStartedError #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-olszewski merged 2 commits into from
Apr 6, 2026
Merged

fix: use workflow type name in WorkflowAlreadyStartedError #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d5298
test: add failing test asserting workflow type
chris-olszewski Apr 6, 2026
fdcc56e
fix: use workflow type name in WorkflowAlreadyStartedError
chris-olszewski Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/internal/client/implementation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def start_update_with_start_workflow(input)
if details
e = Error::WorkflowAlreadyStartedError.new(
workflow_id: start_options.id,
workflow_type: start_req.workflow_type,
workflow_type: start_req.workflow_type.name,
run_id: details.run_id
)
end
Expand Down
12 changes: 8 additions & 4 deletions temporalio/test/worker_workflow_handler_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,14 +742,16 @@ def test_update_with_start_simple
UpdateWithStartWorkflow, 123,
id:, task_queue: worker.task_queue, id_conflict_policy: Temporalio::WorkflowIDConflictPolicy::FAIL
)
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
env.client.execute_update_with_start_workflow(
UpdateWithStartWorkflow.increment_counter, 456, start_workflow_operation:
)
end
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
start_workflow_operation.workflow_handle
end
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
end
end

Expand Down Expand Up @@ -830,15 +832,17 @@ def test_update_with_start_start_fail
UpdateWithStartWorkflow, 123,
id:, task_queue: worker.task_queue, id_conflict_policy: Temporalio::WorkflowIDConflictPolicy::FAIL
)
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
env.client.start_update_with_start_workflow(
UpdateWithStartWorkflow.increment_counter, 456,
wait_for_stage: Temporalio::Client::WorkflowUpdateWaitStage::ACCEPTED, start_workflow_operation:
)
end
assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
err = assert_raises(Temporalio::Error::WorkflowAlreadyStartedError) do
start_workflow_operation.workflow_handle
end
assert_equal 'UpdateWithStartWorkflow', err.workflow_type
end
end

Expand Down
Loading