Skip to content

chore: add ramping percentage to worker deployment routing helper #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chris-olszewski merged 2 commits into from
Jun 11, 2026
+38 −4
Merged

chore: add ramping percentage to worker deployment routing helper #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af17a21
chore: add ramping percentage to worker deployment routing helper
chris-olszewski Jun 9, 2026
bc72049
chore: update to ca-central-1
chris-olszewski Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
TEMPORAL_CLOUD_MTLS_TEST_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}

# For API key tests
TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-east-1.aws.api.temporal.io:7233
TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: ca-central-1.aws.api.temporal.io:7233
TEMPORAL_CLOUD_API_KEY_TEST_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
TEMPORAL_CLOUD_API_KEY_TEST_API_KEY: ${{ secrets.TEMPORAL_CLIENT_CLOUD_API_KEY }}

Expand Down
2 changes: 1 addition & 1 deletion temporalio/test/sig/worker_workflow_versioning_test.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ class WorkerWorkflowVersioningTest < Test
def set_current_deployment_version: (untyped client, String task_queue, Temporalio::WorkerDeploymentVersion version) -> untyped
def set_ramping_version: (untyped client, String task_queue, Temporalio::WorkerDeploymentVersion version, Float rate) -> untyped
def wait_for_workflow_running_on_version: (untyped handle, String expected_build_id) -> void
def wait_for_worker_deployment_routing_config_propagation: (untyped client, String deployment_name, String expected_current_build_id, ?String expected_ramping_build_id) -> void
def wait_for_worker_deployment_routing_config_propagation: (untyped client, String deployment_name, String expected_current_build_id, ?String expected_ramping_build_id, ?Float expected_ramping_percentage) -> void
end
38 changes: 36 additions & 2 deletions temporalio/test/worker_workflow_versioning_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ def test_worker_deployment_version
# Wait for worker v1 to be visible and set as current
describe_resp = wait_until_worker_deployment_visible(env.client, worker_v1)
set_current_deployment_version(env.client, describe_resp.conflict_token, worker_v1)
wait_for_worker_deployment_routing_config_propagation(env.client, deployment_name, worker_v1.build_id)

# Start workflow 1 which will use the 1.0 worker on auto-upgrade
handle1 = env.client.start_workflow(
Expand All @@ -150,6 +151,7 @@ def test_worker_deployment_version
# Set v2 as current deployment
describe_resp2 = wait_until_worker_deployment_visible(env.client, worker_v2)
set_current_deployment_version(env.client, describe_resp2.conflict_token, worker_v2)
wait_for_worker_deployment_routing_config_propagation(env.client, deployment_name, worker_v2.build_id)

# Start workflow 2 which will use the 2.0 worker on pinned
handle2 = env.client.start_workflow(
Expand All @@ -162,6 +164,7 @@ def test_worker_deployment_version
# Set v3 as current deployment
describe_resp3 = wait_until_worker_deployment_visible(env.client, worker_v3)
set_current_deployment_version(env.client, describe_resp3.conflict_token, worker_v3)
wait_for_worker_deployment_routing_config_propagation(env.client, deployment_name, worker_v3.build_id)

# Start workflow 3 which will use the 3.0 worker on auto-upgrade
handle3 = env.client.start_workflow(
Expand Down Expand Up @@ -242,6 +245,13 @@ def test_worker_deployment_ramp
worker_v2,
100.0
).conflict_token
wait_for_worker_deployment_routing_config_propagation(
env.client,
deployment_name,
worker_v1.build_id,
worker_v2.build_id,
100.0
)

# Run workflows and verify they run on v2
3.times do |i|
Expand All @@ -261,6 +271,13 @@ def test_worker_deployment_ramp
worker_v2,
0.0
).conflict_token
wait_for_worker_deployment_routing_config_propagation(
env.client,
deployment_name,
worker_v1.build_id,
worker_v2.build_id,
0.0
)

3.times do |i|
handle = env.client.start_workflow(
Expand All @@ -274,6 +291,13 @@ def test_worker_deployment_ramp

# Set ramp to 50 and eventually verify workflows run on both versions
set_ramping_version(env.client, conflict_token, worker_v2, 50.0)
wait_for_worker_deployment_routing_config_propagation(
env.client,
deployment_name,
worker_v1.build_id,
worker_v2.build_id,
50.0
)
seen_results = Set.new

# Keep running workflows until we've seen both versions
Expand Down Expand Up @@ -350,6 +374,7 @@ def _test_worker_deployment_dynamic_workflow(workflow_class, expected_versioning
worker.run do
describe_resp = wait_until_worker_deployment_visible(env.client, worker_v1)
set_current_deployment_version(env.client, describe_resp.conflict_token, worker_v1)
wait_for_worker_deployment_routing_config_propagation(env.client, deployment_name, worker_v1.build_id)

handle = env.client.start_workflow(
'cooldynamicworkflow',
Expand Down Expand Up @@ -435,6 +460,7 @@ def test_workflows_can_use_default_versioning_behavior
worker.run do
describe_resp = wait_until_worker_deployment_visible(env.client, worker_v1)
set_current_deployment_version(env.client, describe_resp.conflict_token, worker_v1)
wait_for_worker_deployment_routing_config_propagation(env.client, deployment_name, worker_v1.build_id)

handle = env.client.start_workflow(
NoVersioningAnnotationWorkflow,
Expand Down Expand Up @@ -597,6 +623,7 @@ def test_workflows_can_use_versioning_override
describe_resp = wait_until_worker_deployment_visible(env.client, worker_v1)
# Set current deployment version
set_current_deployment_version(env.client, describe_resp.conflict_token, worker_v1)
wait_for_worker_deployment_routing_config_propagation(env.client, deployment_name, worker_v1.build_id)

# Start workflow with pinned versioning override
handle = env.client.start_workflow(
Expand Down Expand Up @@ -798,7 +825,8 @@ def test_continue_as_new_with_ramping_version
env.client,
deployment_name,
worker_v1.build_id,
worker_v2.build_id
worker_v2.build_id,
0.0
)

handle.signal(CanRampingVersionWorkflowV1.do_continue_as_new)
Expand All @@ -821,7 +849,8 @@ def wait_for_workflow_running_on_version(handle, expected_build_id)
end

def wait_for_worker_deployment_routing_config_propagation(
client, deployment_name, expected_current_build_id, expected_ramping_build_id = ''
client, deployment_name, expected_current_build_id, expected_ramping_build_id = '',
expected_ramping_percentage = nil
)
assert_eventually do
res = client.workflow_service.describe_worker_deployment(
Expand All @@ -840,6 +869,11 @@ def wait_for_worker_deployment_routing_config_propagation(
assert_equal expected_ramping_build_id,
routing_config.ramping_deployment_version&.build_id.to_s

unless expected_ramping_percentage.nil?
assert_equal expected_ramping_percentage,
routing_config.ramping_version_percentage
end

state = info.routing_config_update_state
assert(
state == :ROUTING_CONFIG_UPDATE_STATE_COMPLETED ||
Expand Down
Loading