chore: properly clean up schedules in tests#461
Merged
Conversation
d34d447 to
fca28d2
Compare
THardy98
approved these changes
Jun 11, 2026
GregoryTravis
approved these changes
Jun 11, 2026
fca28d2 to
0ec4465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
assert_no_schedules!calls to fail.defined?(handle)as the guard for schedule cleanup to just checking if the handle is present. (defined?(handle)will always be true regardless of if we have schedules or not)Why?
I had
test_calendar_spec_defaultsfail due to schedules from other tests not being cleaned up.Checklist
Closes N/A
How was this tested:
CI
Any docs updates needed?
N/A