Skip to content

chore: properly clean up schedules in tests#461

Merged
chris-olszewski merged 1 commit into
mainfrom
olszewski/chore_proper_schedule_cleanup
Jun 11, 2026
Merged

chore: properly clean up schedules in tests#461
chris-olszewski merged 1 commit into
mainfrom
olszewski/chore_proper_schedule_cleanup

Conversation

@chris-olszewski

Copy link
Copy Markdown
Member

What was changed

  • Save schedule ids incrementally. Previously if one of these schedule creations failed we would not track the schedule id and be unable to clean it up causing future tests's assert_no_schedules! calls to fail.
  • Switch from using defined?(handle) as the guard for schedule cleanup to just checking if the handle is present. (defined?(handle) will always be true regardless of if we have schedules or not)

Why?

I had test_calendar_spec_defaults fail due to schedules from other tests not being cleaned up.

Checklist

  1. Closes N/A

  2. How was this tested:
    CI

  3. Any docs updates needed?
    N/A

@chris-olszewski chris-olszewski requested a review from a team as a code owner June 11, 2026 13:22
@chris-olszewski chris-olszewski force-pushed the olszewski/chore_proper_schedule_cleanup branch from d34d447 to fca28d2 Compare June 11, 2026 13:23
@chris-olszewski chris-olszewski force-pushed the olszewski/chore_proper_schedule_cleanup branch from fca28d2 to 0ec4465 Compare June 11, 2026 21:06
@chris-olszewski chris-olszewski enabled auto-merge (squash) June 11, 2026 21:06
@chris-olszewski chris-olszewski merged commit 16e3509 into main Jun 11, 2026
8 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/chore_proper_schedule_cleanup branch June 11, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants