Implement planned topic: 0024-worker-connections#208
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0024-worker-connections#208skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report —
worker-connections(TypeScript)Skill root:
.Files validated:
references/typescript/worker-connections.md(new, 112 lines)references/typescript/typescript.md(one-line pointer added at line 182)Source of truth used:
../documentation/docs/develop/typescript/Cited docs files:
docs/develop/typescript/client/temporal-client.mdxdocs/develop/typescript/set-up.mdxdocs/develop/typescript/workers/run-process.mdxIntegration topic? No. Check 5 skipped.
Go/no-go
Overall verdict: GO.
Check 1 findings
None. All 23 citations resolve to existing files and the cited text substantively supports the authored claim.
A few citations have a narrower line range than ideal — the claim is correct, but the supporting text in the docs sits just outside the cited window. These are stylistic, not factual:
temporal-client.mdx:612-615): the cite supports "used by a Temporal Application or by code inside an Activity (typically wrapped by Client)" but not the "from@temporalio/client" half of the bullet. That half is supported by lines 487-489 of the same file (cited on the parallel bullet at line 9).run-process.mdx:270-272): cite supports "callWorker.shutdown()for programmatic shutdown" but not "then close the connection" — that's the universal pattern fromset-up.mdx:230-234.temporal-client.mdx:610-615): cite supports the role distinction (NativeConnection = Worker, Connection = App/Activity) but the specific API shapesWorker.create({ connection })andnew Client({ connection })are documented in earlier code examples (e.g. lines 467-468, 489-490). The claim is correct; the cite is just on the role-distinction prose rather than on the code examples.No action required — these don't affect generated code.
Check 2 findings
None. All extracted factual tokens are present in the docs:
NativeConnectionloadClientConnectConfig@temporalio/envconfig@temporalio/worker@temporalio/clientsetApiKeytemporal-client.mdx(lines 473, 476) — both in the Connection (client) section, never in the NativeConnection section. The skill correctly limits the claim to clientConnection.SIGUSR2(and the other three signals)run-process.mdx:255-256TEMPORAL_CONFIG_FILEtemporal-client.mdx:88temporal.tomltemporal-client.mdx:90tmprl.cloudWorker.shutdownrun-process.mdxlocalhost:7233connectionOptions(fromconfig.connectionOptions)apiKey:(as a NativeConnection.connect option)temporal-client.mdx:257, 465, 590Check 3 findings
None.
Greps for the universal regression patterns (
--profile,TEMPORAL_TLS_CLIENT_CERT_PATH,TEMPORAL_TLS_CLIENT_KEY_PATH,TEMPORAL_TLS_SERVER_CA_CERT_PATH,tcld service-account,--output text|jsonl,saas-api.tmprl.cloud) returned no matches in the authored file.The topic-specific regression check — "Import
NativeConnectionfrom@temporalio/client" appearing as guidance — returned three matches, all framed as negative warnings: lines 14, 94, and 108. Each one tells the reader not to do this, with the correct path (@temporalio/worker) given alongside or in context. Not findings.Side note (out of scope for this validation): the docs themselves at
temporal-client.mdx:551-552useTEMPORAL_TLS_CLIENT_CERT_PATHandTEMPORAL_TLS_CLIENT_KEY_PATHin abash exportblock. The skill does not propagate these — it relies onloadClientConnectConfigwhich reads its own set of variables. This is a docs discrepancy, not a skill bug.Check 4 findings
10/10 sampled claims match the docs.
Sample (every-other-citation, with the duplicates collapsed): citations at authored lines 9, 12, 45, 47, 62, 70, 72, 92, 102, 109.
temporal-client.mdx:487-489@temporalio/worker, used by Workers.temporal-client.mdx:614-615set-up.mdx:207-210await NativeConnection.connect(options)returns aNativeConnection.set-up.mdx:230-234await connection.close()infinallyafterworker.run().temporal-client.mdx:558-572loadClientConnectConfig()+NativeConnection.connect(config.connectionOptions)) is identical.run-process.mdx:162-163<Namespace>.<ID>.tmprl.cloud:<port>.run-process.mdx:165temporal-client.mdx:473-477setApiKeydocumented on the Connection object.run-process.mdx:270-272Worker.shutdown()is the programmatic shutdown API; the "then close the connection" half is the universalfinally-block pattern, not in this specific range but consistent with the rest of the docs.temporal-client.mdx:610-615Worker.createtakingconnectionvsClienttakingconnectionis consistent with the earlier code examples on the same page.No substantive divergences.
Check 5 findings
N/A — not an integration topic.
references/typescript/integrations/does not exist and the topic is a core SDK reference (Worker connection lifecycle), not a plugin/contrib module.Check 6 findings
None.
NativeConnection— the local docs do not describe it"), which is a boundary statement, not a workaround disclosure. It tells the agent the limit, not how to get around it.Bonus observation (informational, not a finding): the file contains a
<!-- VERIFY: … -->comment at line 96 explicitly acknowledging that worker-side connection-replacement APIs (analogous tosetApiKeyfor the clientConnection) are not documented in the local docs clone and pointing at the TypeScript API reference site as the likely authoritative source. This is good authoring hygiene — the skill refrains from making a claim it can't ground. It does mean the topic has a small known gap (Worker-side runtime connection mutation isn't covered); that's a scope decision, not a factual error.Statistics
Verdict: GO
The skill is grounded, citations resolve, no fabrications, no regressions, no workaround disclosures. Recommend merging as-is.
Optional polish (does not gate merge):
set-up.mdx:230-234for the "then close the connection" half).End of report.