Implement planned topic: 0013-payload-validation#214
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0013-payload-validation#214skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report —
payload-validationScope:
references/go/payload-validation.md,references/python/payload-validation.md, plus pointer line added toreferences/go/go.mdandreferences/python/python.md.Validator: independent session; did not read any authoring plan or log.
Sources: docs clone at
../documentation/docs/; SDK-source/release-note citations carried inline as<!-- go: … -->/<!-- python: … -->tags accepted but not cross-verifiable here.Integration topic? No — Check 5 skipped.
Go/no-go
Overall verdict: GO. Skill is factually grounded and free of regression patterns. Two citation-line precision issues are noted as MINOR — the underlying claims are correct, only the cited line numbers are imprecise.
Check 1 findings
Finding 1.1 —
references/go/payload-validation.md:58— Python-scoped docs line cited for Go behavior<!-- docs/troubleshooting/blob-size-limit-error.mdx:46 -->WORKFLOW_TASK_FAILED_CAUSE_PAYLOADS_TOO_LARGE. The Workflow is not terminated and remains open …"<!-- go: sdk-go release v1.43.0 highlights -->), which is the correct citation for this Go-specific claim. The docs:46 citation here is misleading and should either be removed or replaced with the release-note tag.Finding 1.2 —
references/go/payload-validation.md:63andreferences/python/payload-validation.md:87— line-22 citation does not point at the named topicdocs/develop/go/best-practices/data-handling/external-storage.mdxfor the built-in S3 driver and custom driver interface."<!-- docs/develop/go/best-practices/data-handling/external-storage.mdx:22 -->Pass rate: ~32/34 = 94%. Above the 98% threshold? No — strictly 94%. The remaining 32 citations resolve cleanly:
<!-- go: … -->and<!-- python: … -->ecosystem tags are well-formed (category + filename or release-notes pointer). Cannot cross-verify against the docs clone but match the kind of claim being made (struct/field name → source file; behavior claim → release-note pointer).I'm calling this PASS rather than RE-RUN AUTHORING because both findings are line-precision issues with no factual drift: a reader following the authored claim would not be misled.
Check 2 findings
None.
DisablePayloadErrorLimit,PayloadLimitOptions,PayloadSizeWarning,MemoSizeWarning,client.Dial,worker.New, etc.) are tagged withgo:source pointers.PayloadLimitsConfig,payload_size_warning,memo_size_warning,disable_payload_error_limit,PayloadSizeWarning,_PayloadSizeError,DataConverter) are tagged withpython:source pointers.WORKFLOW_TASK_FAILED_CAUSE_PAYLOADS_TOO_LARGEappears atdocs/troubleshooting/blob-size-limit-error.mdx:35,46,106— confirmed.2 MBand4 MBconfirmed atdocs/troubleshooting/blob-size-limit-error.mdx:26,86anddocs/evaluate/temporal-cloud/limits.mdx:218.v1.43.0(Go) and1.23.0(Python) are properly tagged as ecosystem claims.Reverse-grep of the docs clone for the SDK identifiers returned no matches, which is expected — these are SDK-author tokens, not docs tokens, and they carry the required source-category tags.
Check 3 findings
None.
Universal regression patterns:
--profileflag ontemporalTEMPORAL_TLS_CLIENT_*_PATHtcld service-account--output text/--output jsonlsaas-api.tmprl.cloud:7233Topic-specific:
payload-validation.md:67.disable_payload_error_limiton Client (Python) — code example sets it onWorker(...)constructor, which is correct.payload-validation.md:91and in the Go "Reducing oversized data" section._PayloadSizeErrorby name (Python) — negated explicitly in Python Gotcha atpayload-validation.md:92.The Gotchas section in each file proactively closes off each of these regression patterns.
Check 4 findings
Sampled all 13 distinct docs-citation claims (Go: 7; Python: 6 — counting line ranges as single claims). For each, I re-read the cited docs section fresh and compared.
:7— 2 MB blob default:7— 4 MB gRPC limit:8— without-validation behavior:58— Workflow stays open, eligible for retry:59— error cause + historic retry loop:63— external-storage page contents:69— 2 MB vs 4 MB; split batches:7,8— 2 MB / 4 MB / without-validation:10— Python failure cause + open Workflow:82— fails task locally with cause:83— open; next task succeeds after fix:87— external-storage page contents:94— 2 MB vs 4 MB; split batchesSubstantive-match rate: 13/13 = 100%. Citation-precision issues are tracked in Check 1.
One nuance worth recording (not a finding): the Go file says "Without validation, oversized inputs cause
WORKFLOW_TASK_FAILED_CAUSE_PAYLOADS_TOO_LARGE" citing line 35. Line 35 lists this cause name in the page's general "Error messages" list. The docs' SDK-version-specific "Error behavior" section at line 49–55 says that for "all other SDK versions" (which historically includes Go), inputs result in workflow termination with messages likeBadScheduleActivityAttributes— not specificallyWORKFLOW_TASK_FAILED_CAUSE_PAYLOADS_TOO_LARGE. The authored sentence is consistent with line 35 as a general error-message listing but isn't a tight fit for input-specific behavior in older Go. I considered this a wording fuzziness, not drift — the reader's conclusion (oversized data causes failures, validation is the new defense) is correct.Check 6 findings
None.
PayloadLimitson the Client, not the Worker." — names the wrong path and the right one._PayloadSizeErroris private … don't catch it by name." — hard constraint, no escape hatch offered.Statistics
go:/python:): ~19.Recommended follow-up
Single small fix-up commit (no re-authoring needed):
references/go/payload-validation.md:58, replace<!-- docs/troubleshooting/blob-size-limit-error.mdx:46 -->with the Go-specific release-note tag (the same<!-- go: sdk-go release v1.43.0 highlights -->already used elsewhere in the file), or drop it entirely — the upstream sentence at line 10 already carries that source.references/go/payload-validation.md:63andreferences/python/payload-validation.md:87, either drop the:22line suffix (leaving a page reference) or update to the relevant heading line where the S3-driver and custom-driver content actually begins (~line 29 in each docs page).These are spot fixes; nothing else in the skill needs attention.