Implement planned topic: 0038-vercel-ai-sdk#246
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0038-vercel-ai-sdk#246skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Validation Report —
0038-vercel-ai-sdkSkill: Vercel AI SDK (TypeScript integration)
Skill root:
.Branch:
draft/0038-vercel-ai-sdkFiles under review (uncommitted on this draft branch):
references/typescript/integrations/vercel-ai-sdk.md(new, 200 lines)references/integrations.md(one row added)Primary docs source:
../documentation/docs/develop/typescript/integrations/ai-sdk.mdx(275 lines)This is a third-party integration topic with a catalog convention in place, so Check 5 applies. The topic ships a per-language API only (TypeScript), so Check 7 does not apply.
Go/no-go
Overall verdict: GO. All applicable checks pass their thresholds. No findings warrant a re-authoring pass or spot-fix.
Check 1 findings — citation audit
Mechanically resolved every
<!-- docs/… -->inline comment inreferences/typescript/integrations/vercel-ai-sdk.md. All citations point todocs/develop/typescript/integrations/ai-sdk.mdx, which exists (275 lines).generateText()as Activities; tools/MCP framing reinforced by 152–158 / 209–215 elsewhere in same file.:::infoblock marks Public Preview.:::tipblock.import * as activities from './activities'which is the expected expansion of the docs’ omitted-imports comment.proxyActivitiesis the canonical mechanism shown in the code block below at 180.AiSdkPluginoptions)new TemporalMCPClient({ name: 'testServer' }).ai-sdk.dev/providers/ai-sdk-providersis the link surfaced in the docs.Pass criterion (≥ 98%): 28/28 = 100% resolve cleanly.
Hyperlink check. User-facing links at the bottom of the file:
https://docs.temporal.io/develop/typescript/integrations/ai-sdk— full URL ✓https://ai-sdk.dev/andhttps://ai-sdk.dev/providers/ai-sdk-providers— both full URLs ✓No root-relative
/develop/...paths found.Check 2 findings — reverse-grep audit
Token classes extracted from
vercel-ai-sdk.mdand grepped againstdocs/develop/typescript/integrations/ai-sdk.mdx:@temporalio/ai-sdk,@ai-sdk/openai,@ai-sdk/mcp,@modelcontextprotocol/sdk/client/stdio.js)AiSdkPlugin,temporalProvider,temporalProvider.languageModel,TemporalMCPClient,experimental_createMCPClient,createMCPClient,StdioClientTransport,proxyActivities,generateText,tool)modelProvider,mcpClientFactories)plugins,connection,namespace,taskQueue,workflowsPath,activities)model,prompt,system,tools,description,inputSchema,execute,stopWhen,stepCountIs)'gpt-4o-mini','ai-sdk','default','testServer','14-20C','Sunny with wind.','You only respond in haikus.')Pass criterion (zero unexplained grep-misses): zero misses. PASS.
Check 3 findings — regression on known bugs
Scanned for all universal regression patterns:
--profileas a flag intemporalTEMPORAL_TLS_CLIENT_CERT_PATH/_KEY_PATH/_SERVER_CA_CERT_PATHtcld service-account--output text/--output jsonlsaas-api.tmprl.cloud:7233No topic-specific regressions exist for this file. PASS.
Check 4 findings — independent re-verification
Sampled 10 claims; for each, opened the cited docs region independently and compared the authored phrasing.
AiSdkPluginonWorker.createand pass amodelProvider"proxyActivitiesmcpClientFactoriesis a map keyed by server name; multiple servers register by adding factory entriesStdioClientTransport: Worker starts MCP server process on demand per TaskTemporalMCPClientobject-form constructor;await mcpClient.tools()returns tools to pass togenerateTextPrerequisite/minimum-version spot-check: L15 only cites the standard TS SDK setup (CLI + the four
@temporalio/*packages) — no version pins. The docs make no version requirement either. Acceptable absence.Defaults check: the only knob with a documented value the authored file mentions is
startToCloseTimeout: '1 minute'inside the code block; this is the docs' example value, not a default. AI SDK options likestopWhen: stepCountIs(5)mirror the docs example exactly.Pass criterion (≥ 95%): 10/10 = 100%. PASS.
Check 5 findings — integration-layout audit
references/typescript/integrations/vercel-ai-sdk.mdreferences/integrations.mdSKILL.mdeditgit diffshows no change toSKILL.mdreferences/typescript/typescript.mdgit diffshows no change toreferences/typescript/typescript.mdreferences/typescript/ai-patterns.md(file does not exist) orreferences/core/ai-patterns.mdAll six sub-checks pass.
Check 6 findings — tone and scope audit
Walked the file bullet-by-bullet against the 15 finding patterns.
Pattern 1 (workaround / escape-hatch disclosure): none found. The "Common mistakes" section names hard constraints (delegate I/O to Activities, use object-form constructor, match TQ/NS, keep credentials Worker-side) without disclosing escape hatches.
Pattern 2–4 (in-the-weeds rationale, implementation-internals speculation, multi-sentence noise bullets): none. Bullets are short and actionable.
Pattern 5 (Public Preview admonition): present at L7–9 with exact standard phrasing. PASS.
Pattern 6–7 (duplicated / post-admonition release-stage chatter): only one Public Preview note; nothing else restates preview status.
Pattern 8 (speculative common mistakes): the six "Common mistakes" bullets each map to a specific docs claim — no random typo speculation.
Pattern 9 (duplicated hard-constraint lists): the no-fetch-in-tools constraint appears only once.
Pattern 10 (Resources pointing at raw source trees): "Additional Resources" cites the canonical Temporal docs page, the upstream Vercel AI SDK docs, and two sibling reference files — no raw source-tree links.
Pattern 11 (external links duplicating local coverage): N/A — the upstream AI SDK docs are the authoritative API source, and no equivalent local file exists.
Pattern 12 (DIY rebuilds of supported integrations): N/A — file teaches the supported
@temporalio/ai-sdkintegration end-to-end.Pattern 13 (repo slang / internal jargon): none.
Pattern 14 (inline imports in examples): all imports sit at module scope in every code block.
Pattern 15 (ambiguous "context" references): none.
PASS.
Statistics
references/typescript/integrations/vercel-ai-sdk.md,references/integrations.md)Verdict
GO. Skill is grounded in the cited docs, free of regression patterns, structurally compliant with the integration catalog convention, and free of workaround-disclosure or scope-creep findings. Safe to merge.