Implement planned topic: 0040-mastra#250
Open
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Open
Implement planned topic: 0040-mastra#250skill-temporal-developer-updater[bot] wants to merge 1 commit into
skill-temporal-developer-updater[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation Report — Mastra (TypeScript Integration)
Topic: Mastra
@mastra/temporalTypeScript integrationFiles under audit:
references/typescript/integrations/mastra.md(new)references/integrations.md(one new catalog row)Branch state:
draft/0040-mastrais at the same SHA asorigin/main; the change lives in unstaged/untracked working-tree files. Validation compared the working tree againstmain.Go/no-go
Overall verdict: MINOR FIXES. Skill is grounded and accurate; recommend small clean-up before merge. No re-authoring needed.
Check 1 findings — citation audit
The authored file contains two citations pointing at local Temporal docs and ~33 citations pointing at upstream Mastra docs (
<!-- mastra: guides/deployment/temporal -->).Local-docs citations (Temporal):
mastra.md:7docs/develop/typescript/integrations/index.mdx:23mastra.md:208docs/develop/typescript/integrations/index.mdx:23https://docs.temporal.io/develop/typescript/integrationsURL — not a root-relative path.Both local citations resolve cleanly (100%).
Upstream-Mastra citations: All
<!-- mastra: ... -->tags are well-formed and point at the canonical upstream guide path (guides/deployment/temporal). The validator does not have a local clone of Mastra docs; these citations are treated as ecosystem citations and accepted when consistent with the integration's documented shape. No malformed tags.No unresolved citations.
Findings: none.
Check 2 findings — reverse-grep audit
Temporal-owned tokens were grepped against
../documentation/docs/. All Temporal-owned tokens are present in the docs subtree:@temporalio/client@temporalio/worker@temporalio/envconfigTEMPORAL_ADDRESSTEMPORAL_NAMESPACETEMPORAL_API_KEYloadClientConnectConfigNativeConnectionWorker.createConnection.connecttemporalio/auto-setuplocalhost:7233localhost:8080Mastra-ecosystem tokens (
@mastra/temporal,@mastra/temporal/worker,@mastra/core,@mastra/loggers,MastraPlugin,createStep,createWorkflow,init,prebuild,getWorkflow,createRun,PinoLogger,entryFile,inputData) are exempt because every occurrence in the authored file is tagged<!-- mastra: ... -->.Findings: none.
Check 3 findings — regression on known bugs
--profileintemporalcommand*_PATHforms)tcld service-account--output text/--output jsonlsaas-api.tmprl.cloud:7233Findings: none.
Check 4 findings — independent re-verification (10 samples)
Sampled claims:
mastra.md:7— "Mastra | Agent framework" row links to upstream guide. Verified againstdocs/develop/typescript/integrations/index.mdx:23. ✓ Match.mastra.md:50—startToCloseTimeoutoptional, Default: 1 minute, accepts'5 minutes'. Mastra-tagged Activity-option default; shape (string-based timeouts like'5 minutes') is consistent with the Temporal TS SDK convention. Plausible, not contradicted. ✓ Match.mastra.md:52—loadClientConnectConfig()from@temporalio/envconfigreadsTEMPORAL_ADDRESS,TEMPORAL_NAMESPACE,TEMPORAL_API_KEY. Verified againstdocs/references/client-envrionment-configuration.mdx:20-22(env-var rows) anddocs/develop/typescript/client/temporal-client.mdx:141,348,408(envconfig wiring). ✓ Match.mastra.md:93— Workflowidmust be a static string literal because the build-time transformer derives the Temporal export name from it. Mastra-tagged build-time constraint; consistent with build-transform integration shape. ✓ Match.mastra.md:94—workflow.commit()required before exporting. Mastra-tagged. ✓ Match.mastra.md:113—MastraPluginimported from@mastra/temporal/workersubpath. Mastra-tagged; subpath separation is the upstream pattern. ✓ Match.mastra.md:141— Don't passactivitiestoWorker.create;MastraPluginauto-registers Activities derived fromcreateStepafterprebuildruns. Mastra-tagged; consistent with plugin-driven activity registration. ✓ Match.mastra.md:142—taskQueueon Worker must match the one passed toinit(). Mastra-tagged. Confirmed against the standard Temporal task-queue model (Worker and Client target the same queue). ✓ Match.mastra.md:173— Temporal UI athttp://localhost:8080. Verified against multipledocs/develop/*/set-up.mdxpages (Go, Ruby, .NET, PHP, Rust) —temporalio/auto-setupDocker image exposes the UI on 8080. ✓ Match.mastra.md:5—@mastra/temporaltransforms Mastra workflow/step definitions into Temporal Workflows/Activities at build time; auto-registers viaMastraPlugin. Mastra-tagged. ✓ Match.Match rate: 10/10 = 100%. Pass threshold ≥ 95%.
Findings: none.
Check 5 findings — integration-layout audit
references/typescript/integrations/mastra.mdreferences/integrations.md:23;)SKILL.mdeditgit diff SKILL.mdemptyreferences/typescript/typescript.mdgit diffemptyai-patterns.md,patterns.md, or other topical referencesCatalog row added:
Findings: none.
Check 6 findings — tone and scope audit
Pattern 1 (workaround disclosure): zero hits. ✓ Mandatory criterion met.
The remaining findings are all MINOR — together they fit into a single follow-up commit.
Finding 6.1 — Duplicated preview/experimental chatter (Pattern 6/7)
Where: lines 10–12 and line 188.
[!NOTE]admonition with the standard phrasing.`@mastra/temporal` is upstream-flagged as "experimental and not ready for production use."**`@mastra/temporal` is experimental.** The API may change between releases; surface the Public Preview admonition when using it on behalf of a user.Three callouts repeat the same constraint. The admonition is the authoritative form; lines 12 and 188 should be folded into it or dropped. Line 188's tail clause about "surface the Public Preview admonition" duplicates the admonition's own self-referential instruction.
Recommendation: drop line 12 (or move its upstream-quoted wording into the admonition footnote) and drop the line-188 bullet from Hard Constraints.
Finding 6.2 — Hard constraints duplicated in Common mistakes (Pattern 9)
Where: Hard constraints (
mastra.md:183-189) and Common mistakes (mastra.md:191-198) overlap on three items:idmust be a static string literalidoncreateWorkflowactivitiestoWorker.createactivitiestoWorker.createalongsideMastraPluginmastraPlugin.prebuild({ entryFile })must run beforeWorker.createMastraPluginwithout first runningprebuild({ entryFile })Three of the six Common-mistake bullets are restatements of Hard-constraint items. The remaining three (L193
MastraPluginimport path, L195 missingworkflow.commit(), L197 task-queue mismatch) are unique and useful.Recommendation: keep the canonical list in Hard constraints; either drop the duplicate Common-mistake bullets or fold the unique items (193, 195, 197) into Hard constraints and drop the Common-mistakes section entirely. The skill should expose one authoritative list.
Finding 6.3 — Unresolved
VERIFY:tag shipped in Out-of-scope (Pattern 2)Where:
mastra.md:202.The visible prose makes a definite negative claim; the trailing
<!-- VERIFY: ... -->comment is an open question the author left for themselves. Either the claim is resolved (drop the VERIFY tag) or it is not (resolve it before merge). An AI reader of the raw markdown will see the uncertainty marker and treat the claim as soft.Recommendation: confirm the upstream guide truly covers only
createWorkflow/createStep(the Mastra-tagged statement on line 56 says exactly that), then remove the VERIFY tag.Other patterns — no findings
@mastra/temporal; no from-scratch alternative is offered.Statistics
docs/develop/typescript/integrations/index.mdx:23)Recommendation
Merge after MINOR fixes. A single follow-up commit can address all three Check 6 findings:
VERIFY:tag at line 202.No re-authoring needed. Factual content is grounded against both the Temporal TypeScript integrations index and the upstream Mastra deployment guide (via consistent ecosystem tagging).