Replacing favicon PNG with SVG for favicon and footer image#468
Merged
Conversation
The previous commit set the SVG via the `favicon` config but then appended a PNG `<link rel="icon">` via headTags. Because headTags are rendered after the auto-generated favicon link, browsers picked the PNG as the active icon. Swap the order so the PNG is the untyped fallback and the SVG is declared with `type="image/svg+xml"` — modern browsers will prefer the SVG, older browsers fall back to the PNG. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
|
Contributor
|
LGTM - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added an SVG version of the favicon. Replaced the favicon in the head with the SVG version and retained png as a fallback.
Replaced footer image to reference the SVG.
Why?
The favicon.png is in the footer of every page. The image is 520x520 but displayed as 24x24. The size was unnecessarily large and flagged by Google Lighthouse as an easy global fix.
This replaces the 184kb PNG for a 4kb SVG and maintains user experience for the favicon and footer icon.
Checklist
How was this tested:
Built the site locally. On /courses, the lighthouse performance score improved from 57 - 67. Favicon renders correctly in Chrome. Image in the footer shows, still links to the right site, and looks the same.
Any docs updates needed?
No