Skip to content

feat: add KEDA/HPA managed scaling support #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m1rl0k wants to merge 1 commit into from
Closed

feat: add KEDA/HPA managed scaling support #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions internal/controller/genplan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,23 @@ func (r *TemporalWorkerDeploymentReconciler) generatePlan(
plan.ScaleDeployments = planResult.ScaleDeployments
plan.UpdateDeployments = planResult.UpdateDeployments

// If KEDA/HPA managed, only keep scale-to-zero operations (for sunset behavior).
if _, ok := w.GetAnnotations()["temporal.io/keda-managed"]; ok {
for ref, replicas := range plan.ScaleDeployments {
if replicas > 0 {
delete(plan.ScaleDeployments, ref)
}
}
// Preserve existing replicas in UpdateDeployments to avoid fighting KEDA.
for _, d := range plan.UpdateDeployments {
if buildID, hasBuildID := d.Labels[k8s.BuildIDLabel]; hasBuildID {
if existing, found := k8sState.Deployments[buildID]; found && existing.Spec.Replicas != nil {
d.Spec.Replicas = existing.Spec.Replicas
}
}
}
}

// Convert version config
plan.UpdateVersionConfig = planResult.VersionConfig

Expand Down