Handle permission errors explicitly in readConfigFile#10568
Open
NasitSony wants to merge 1 commit into
Open
Conversation
When os.ReadFile fails due to permission denied, return a specific error message instead of the generic 'could not read config file' message. This makes permission issues immediately identifiable without needing to inspect the wrapped error. Fixes temporalio#7048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When os.ReadFile fails due to permission denied, return a specific error message instead of the generic 'could not read config file' message. This makes permission issues immediately identifiable without needing to inspect the wrapped error.
Fixes #7048
What changed?
Added explicit handling for
os.ErrPermissioninreadConfigFileto return a clear, specific error message when a config file cannot
be read due to permission issues.
Why?
Permission errors were wrapped in a generic "could not read config
file" message, making it hard to distinguish permission issues from
other read errors. Now permission errors return a specific
"permission denied reading config file" message that immediately
identifies the root cause.
How did you test it?
Potential risks
None — additive error handling only. No behavior change for
non-permission errors. Permission denied errors now return a
more descriptive message instead of the generic one.