Skip to content

feat(DT-4077): add delete Worker Deployment action#3510

Draft
rossnelson wants to merge 1 commit into
dt-4079from
dt-4077
Draft

feat(DT-4077): add delete Worker Deployment action#3510
rossnelson wants to merge 1 commit into
dt-4079from
dt-4077

Conversation

@rossnelson

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a kebab actions menu to the Worker Deployments list with a Delete item
  • Shows a blocked modal ("Cannot Delete Worker Deployment") when the deployment has versions, directing the user to delete each version first
  • Shows a destructive confirm modal (requiring the user to type DELETE) when all versions have been removed
  • Refreshes the deployments list after a successful delete

Notes

  • Deleting the current version to reach an empty deployment requires unsetting it to "unversioned" first — that path will be addressed in DT-4079

Test plan

  • Deployments list shows a ⋮ actions column with a Delete item per row
  • Clicking Delete on a deployment with versions shows the blocked modal (no confirm button)
  • Clicking Delete on a deployment with no versions shows the destructive confirm modal
  • Typing DELETE and confirming removes the deployment and refreshes the list
  • Errors from the API surface in the modal

@rossnelson rossnelson requested a review from a team as a code owner June 8, 2026 19:26
@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Jun 8, 2026 8:36pm

Request Review

{open}
confirmText=""
cancelText={translate('common.close')}
hideConfirm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Argument of type '(() => void) | undefined' is not assignable to parameter of type '(e: CustomEvent) => void'.

@temporal-cicd

temporal-cicd Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

📊 Strict Mode: 1 error in 1 file (0.1% of 913 total)

src/lib/components/deployments/delete-deployment-modal.svelte (1)
  • L31:20: Argument of type '(() => void) | undefined' is not assignable to parameter of type '(e: CustomEvent) => void'.

Generated by 🚫 dangerJS against bdc0057

@rossnelson rossnelson changed the base branch from main to dt-4079 June 8, 2026 20:28
@rossnelson rossnelson marked this pull request as draft June 8, 2026 20:29
Adds a kebab actions menu to the deployments list with a Delete item.
Shows a blocked modal when versions exist (all must be removed first),
or a destructive confirm modal requiring the user to type DELETE when
the deployment has no versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant