feat(DT-4079): miscellaneous WD UI fixes#3511
Draft
rossnelson wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
- Hide "Set Current Version" menu item for versions already current - Re-arrange deployment detail header: Create New Version as primary, More Actions menu with View Workflows / Ramp to Unversioned / Delete - Add Ramp to Unversioned Workers modal with percentage input - Show alert banner when unversioned workers are ramping with Edit/Delete actions - Remove border box from ComputeBadge — use plain icon + label styling
Calls set-current-version with an empty version string, transitioning the version to Draining then Drained so it can be deleted. Prerequisite for fully emptying a deployment (DT-4077).
…tion to modal Replace custom banner div with Alert component; remove inline Edit/Delete buttons. Move the remove action into the Ramp to Unversioned Workers modal as a destructive footer button, shown only when ramping is active.
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| {open} | ||
| confirmText={translate('common.confirm')} | ||
| cancelText={translate('common.cancel')} | ||
| on:confirmModal={() => onConfirm?.(percentage)} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type '(() => void) | undefined' is not assignable to parameter of type '(e: CustomEvent) => void'.
| slot="footer" | ||
| variant="destructive" | ||
| size="sm" | ||
| class={!onRemove ? 'invisible' : ''} |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type '(() => void) | undefined' is not assignable to parameter of type '(e: PointerEvent) => void'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set-ramping-versionAPI with emptybuild_id[icon] labelmatching the Namespace Region styleset-current-versionwith an empty version string, which transitions the version to Draining and eventually Drained, allowing it to be deleted. Without this, a deployment could never be fully emptied (and therefore never deleted) because one version is always pinned as current.Test plan