Skip to content

The fully_commutes_with_sum property was incorrectly using sum() on the flattened commuting structure, which does not yield a boolean. Changed to use all() to ensure the property returns True only if all sub-encoders fully commute with sum. Added type assertions in tests to verify the return type is boolean. #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

The fully_commutes_with_sum property was incorrectly using sum() on the flattened commuting structure, which does not yield a boolean. Changed to use all() to ensure the property returns True only if all sub-encoders fully commute with sum. Added type assertions in tests to verify the return type is boolean. #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorflow_model_optimization/python/core/internal/tensor_encoding/core/gather_encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def input_tensorspec(self):
@property
def fully_commutes_with_sum(self):
# If any element is not True, the whole thing does not fully commute.
return sum(tf.nest.flatten(self._commuting_structure))
return all(tf.nest.flatten(self._commuting_structure))

@property
def state_update_aggregation_modes(self):
Expand Down
3 changes: 3 additions & 0 deletions ...rflow_model_optimization/python/core/internal/tensor_encoding/core/gather_encoder_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,12 +198,14 @@ def test_full_commutativity_with_sum(self):
core_encoder.EncoderComposer(test_utils.TimesTwoEncodingStage()).make(),
spec)
self.assertTrue(encoder.fully_commutes_with_sum)
self.assertIsInstance(encoder.fully_commutes_with_sum, bool)

encoder = gather_encoder.GatherEncoder.from_encoder(
core_encoder.EncoderComposer(
test_utils.TimesTwoEncodingStage()).add_parent(
test_utils.TimesTwoEncodingStage(), T2_VALS).make(), spec)
self.assertTrue(encoder.fully_commutes_with_sum)
self.assertIsInstance(encoder.fully_commutes_with_sum, bool)

encoder = core_encoder.EncoderComposer(
test_utils.SignIntFloatEncodingStage())
Expand All @@ -213,6 +215,7 @@ def test_full_commutativity_with_sum(self):
test_utils.PlusOneOverNEncodingStage(), T2_VALS)
encoder = gather_encoder.GatherEncoder.from_encoder(encoder.make(), spec)
self.assertFalse(encoder.fully_commutes_with_sum)
self.assertIsInstance(encoder.fully_commutes_with_sum, bool)

@tf_test_util.run_all_in_graph_and_eager_modes
def test_state_aggregation_modes(self):
Expand Down
Loading