Skip to content

[Orbit] Fix type hints in new_best_metric.py #13592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LINYV0719 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Orbit] Fix type hints in new_best_metric.py #13592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions orbit/actions/new_best_metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class JSONPersistedValue:

def __init__(self,
initial_value: Any,
filename: str,
filename: Optional[str],
write_value: bool = True):
"""Initializes the instance.

Expand Down Expand Up @@ -206,11 +206,11 @@ def __init__(self,
if self._value is None:
self.write(initial_value)

def read(self):
def read(self) -> Any:
"""Returns the value."""
return self._value

def write(self, value):
def write(self, value: Any) -> None:
"""Writes the value, updating the backing store if one was provided."""
self._value = value
if self._filename is not None and self._write_value:
Expand Down