Validate weight file paths stay within the model directory#8714
Open
adilburaksen wants to merge 1 commit into
Open
Validate weight file paths stay within the model directory#8714adilburaksen wants to merge 1 commit into
adilburaksen wants to merge 1 commit into
Conversation
In tfjs-node, NodeFileSystem.loadWeights joins each weightsManifest path from the model's weights manifest onto the model directory and reads it, without checking that the result stays inside that directory. Because the manifest is untrusted input, a path containing '..' or an absolute path could read a file outside the model directory. Resolve each weight file path and require it to remain within the model directory before reading it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tfjs-node,NodeFileSystem.loadWeights(tfjs-node/src/io/file_system.ts) joins each path from the model's weights manifest onto the model directory and reads it, without verifying the result stays inside that directory. The manifest is untrusted input, so a path containing..or an absolute path can read a file outside the model directory.This resolves each weight file path and requires it to remain within the model directory before reading. Relative paths under the model directory are unaffected.