Add default wait strategy hook#1340
Open
cristianrgreco wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
2361243 to
2779730
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDefaultWaitStrategy()hook for container subclasses.GenericContainersubclasses.Verification
npm run test -- packages/testcontainers/src/wait-strategies/utils/wait-strategy-selector.test.tsnpm run check-compilesnpm run lintnpm run formatgit diff --checkTest Results
All listed checks passed locally.
Semver Impact
Minor. This adds a backward-compatible protected hook for subclasses without changing existing explicit wait strategy or healthcheck precedence. Existing containers still default to
Wait.forListeningPorts()when no explicit/default wait strategy or healthcheck is available.