-
Notifications
You must be signed in to change notification settings - Fork 88
Stlc theory #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Stlc theory #454
Conversation
New pages
Changed pages
|
|
I'm going to not push anything up here for a little bit while I work on the substitution problem; I feel like it's going to be quite messy while I figure it all out. |
|
Sorry about the slightly sloppy commits, I'm happy to squash them before any of this is merged. |
|
I'm going to tentatively open this up to review. Currently does not include strong normalization & related, as discussed on the Discord. |
TOTBWF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been looking forward to this PR for a while, glad to see it's ready to review 🥳
I'm going to split my review into a couple of rounds to avoid burying you in a mountain of requested changes. First pass is style stuff in Lang.STLC.Named.
Some general notes:
- We might want to consider some
variableblocks for things like contexts: this could shorten a lot of type signatures. - We might want to consider a
Data.List.Snocwith some pattern-fu to make goals always show up as snoc rather than cons, along with some re-exports of flipped append and the like. Alternatively, we can Uphold Snoc List Thought and just haveData.Bwdas a bona-fide data type. Not sure about the best design here, @ncfavier @plt-amy thoughts?
Finally, are you okay with me making edits to the PR directly? If so, I could do a formatting pass myself to save you the trouble. However, if you want to do it yourself to get a better feel for the style guide, that's totally fine by me 🙂
Co-authored-by: Reed Mullanix <reedmullanix@gmail.com>
|
I'll ping again this is ready for review again (once all suggestions are fixed, and I've fixed some stuff I've personally noted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this when we have https://1lab.dev/Cat.CartesianClosed.Free.Lambda.html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps not? That page takes a much more evaluation-centric view, so it might still be nice to have a reduction-centric view around somewhere though.
|
This is ready for a proper review again, now (page: @TOTBWF). I believe most everything has been addressed nix ongoing discussion points? (and CBV, but I have some larger ideas there that can perhaps wait) Also: Formatting is still being worked on, so don't worry about that, and I'll push something to fix the build when I get the chance. |
Co-authored-by: Amélia <me@amelia.how>
Description
Added a very simple STLC, alongside several properties. Still WIP.
Checklist
Before submitting a merge request, please check the items below:
support/sort-imports.hs(ornix run --experimental-features nix-command -f . sort-imports).