Skip to content

Conversation

@jake-87
Copy link
Contributor

@jake-87 jake-87 commented Jan 8, 2025

Description

Added a very simple STLC, alongside several properties. Still WIP.

Checklist

Before submitting a merge request, please check the items below:

  • I've read the contributing guidelines.
  • The imports of new modules have been sorted with support/sort-imports.hs (or nix run --experimental-features nix-command -f . sort-imports).
  • All new code blocks have "agda" as their language.

@Lavenza
Copy link
Member

Lavenza commented Jan 8, 2025

Pull request preview

New pages
Changed pages

@jake-87
Copy link
Contributor Author

jake-87 commented Jan 11, 2025

I'm going to not push anything up here for a little bit while I work on the substitution problem; I feel like it's going to be quite messy while I figure it all out.

@jake-87
Copy link
Contributor Author

jake-87 commented Jun 4, 2025

Sorry about the slightly sloppy commits, I'm happy to squash them before any of this is merged.
Still very much a WIP.

@jake-87
Copy link
Contributor Author

jake-87 commented Jun 12, 2025

I'm going to tentatively open this up to review. Currently does not include strong normalization & related, as discussed on the Discord.
Also needs a base page that links to the three.
@TOTBWF Would especially appreciate your input, if/when you have the time :)

@jake-87 jake-87 marked this pull request as ready for review June 12, 2025 10:41
Copy link
Collaborator

@TOTBWF TOTBWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking forward to this PR for a while, glad to see it's ready to review 🥳

I'm going to split my review into a couple of rounds to avoid burying you in a mountain of requested changes. First pass is style stuff in Lang.STLC.Named.

Some general notes:

  • We might want to consider some variable blocks for things like contexts: this could shorten a lot of type signatures.
  • We might want to consider a Data.List.Snoc with some pattern-fu to make goals always show up as snoc rather than cons, along with some re-exports of flipped append and the like. Alternatively, we can Uphold Snoc List Thought and just have Data.Bwd as a bona-fide data type. Not sure about the best design here, @ncfavier @plt-amy thoughts?

Finally, are you okay with me making edits to the PR directly? If so, I could do a formatting pass myself to save you the trouble. However, if you want to do it yourself to get a better feel for the style guide, that's totally fine by me 🙂

Co-authored-by: Reed Mullanix <reedmullanix@gmail.com>
@jake-87
Copy link
Contributor Author

jake-87 commented Jul 3, 2025

I'll ping again this is ready for review again (once all suggestions are fixed, and I've fixed some stuff I've personally noted)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps not? That page takes a much more evaluation-centric view, so it might still be nice to have a reduction-centric view around somewhere though.

@jake-87
Copy link
Contributor Author

jake-87 commented Aug 24, 2025

This is ready for a proper review again, now (page: @TOTBWF). I believe most everything has been addressed nix ongoing discussion points? (and CBV, but I have some larger ideas there that can perhaps wait)

Also: Formatting is still being worked on, so don't worry about that, and I'll push something to fix the build when I get the chance.

Co-authored-by: Amélia <me@amelia.how>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants