Improving error handling#169
Merged
Merged
Conversation
…-closing archives, not printing the same errors twice
thomaslaurenson
approved these changes
Jun 6, 2026
thomaslaurenson
left a comment
thomaslaurenson
left a comment
Collaborator
There was a problem hiding this comment.
This is another great PR. Some nice cleanup of some bad old code (the duplicate error message), and some great new functionality (the error checking using Stormlib errors). Happy to merge as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenMpqArchivefails - the function already prints that.