refactor(2026-06): gitattributes/editorconfig + triage module + package.json + changelog guard + action alignment#23
Conversation
…s triplicated; workflow + tests now import it)
…ified functional) + CONTRIBUTING note
…dency-review v5, gitleaks v3)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 561a3a0837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PACKAGE_JSON = REPO / "package.json" | ||
| CHANGELOG = REPO / "CHANGELOG.md" |
There was a problem hiding this comment.
This guard reads package.json and CHANGELOG.md, but I checked .github/workflows/skill-validate.yml and its PR/push paths filter only includes SKILL/reference/test/secret/workflow files, not either of these inputs. A PR that only bumps the package version or edits the changelog will therefore skip the unittest job, so the new sync test will not protect the drift it is meant to catch; add these files to the validation trigger or remove the path filter.
Useful? React with 👍 / 👎.
| impact_value = impact(issue.get("labels", [])) | ||
| effort_value = effort(issue.get("body", "")) | ||
| age = (now - _parse_created_at(issue["createdAt"])).days | ||
| comments = int(issue.get("comments", 0) or 0) |
There was a problem hiding this comment.
When the weekly workflow fetches any issue with at least one comment, gh issue list --json comments supplies comments as a list of comment objects, so int([...]) raises TypeError before rendering the summary. The previous inline code only compared this value after the age check; this cast makes even a freshly-created commented issue abort the run, so use len(comments) or totalCount instead of int-casting the raw field.
Useful? React with 👍 / 👎.
1 participant
refactor-2026-06 — github-flow-kit
Verification: 16 unittest pass; yaml + compileall OK. PUBLIC → admin-merge on CI green.