π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in skills import#128
π‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in skills import#128thirdeyenation wants to merge 1 commit into
Conversation
Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Zip Slip (path traversal) vulnerability identified in
helpers/skills_import.pyduring ZIP archive extraction. Malicious archives could write outside the intended extraction directory.π― Impact: An attacker providing a maliciously crafted ZIP file could overwrite arbitrary files on the system with the application's privileges.
π§ Fix: Added explicit path validation iterating over
z.namelist(), checking if the resolvedmember_pathremains within the target directory usingfiles.is_in_dirbefore allowingz.extractall().β Verification: Tested extraction of safe paths manually. Ran full Python test suite (
/home/jules/.local/bin/pytest tests/).PR created automatically by Jules for task 2863893557437782782 started by @thirdeyenation