⚡ Bolt: [performance improvement] Replace blocking time.sleep with await asyncio.sleep in async functions#133
Conversation
Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced synchronous
time.sleep()calls insideasync defmethods withawait asyncio.sleep()inapi/mcp_servers_apply.pyandplugins/_code_execution/helpers/shell_ssh.py. Addedimport asynciowhere necessary. Documented the learning in.jules/bolt.md.🎯 Why: Using synchronous
time.sleep()inside asynchronous methods blocks the entire event loop. In theshell_ssh.pyconnect method, this could block the event loop for up to 5 seconds during retry attempts, severely degrading overall system concurrency and making the application unresponsive to other async tasks.📊 Impact: Prevents event loop freezing during delays, allowing other asynchronous operations (like handling API requests or websocket messages) to continue executing concurrently.
🔬 Measurement: Verify via
pytesttests or by simulating a delayed SSH connection/MCP apply and confirming that other API endpoints remain responsive during the delay.PR created automatically by Jules for task 15128892254534048932 started by @thirdeyenation