π‘οΈ Sentinel: [CRITICAL] Fix path traversal (Zip Slip) in skills import#134
π‘οΈ Sentinel: [CRITICAL] Fix path traversal (Zip Slip) in skills import#134thirdeyenation wants to merge 1 commit into
Conversation
Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: A path traversal (Zip Slip) vulnerability was found in
helpers/skills_import.pywherezipfile.ZipFile.extractall()was called on uploaded zip files without any path containment checks. A malicious zip file containing paths like../../../etc/passwdcould overwrite arbitrary files on the system during extraction.π― Impact: Arbitrary File Overwrite / Remote Code Execution (RCE) if an attacker can upload a crafted skill zip file.
π§ Fix: Updated
_unzip_to_temp_dirto explicitly resolve the target directory and iterate through every file in the zip archive (z.namelist()), verifying that each file's resolved path is completely contained within the target extraction directory (Path.is_relative_to()) before performing the extraction. If any file attempts to escape the directory, extraction is safely aborted with aValueError.β Verification: Ran unit tests specifically testing safe extraction and catching unsafe extraction paths successfully, confirming the protection is active.
PR created automatically by Jules for task 14245286688391670179 started by @thirdeyenation