Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in skill imports#138

Open
thirdeyenation wants to merge 1 commit into
mainfrom
sentinel/fix-zip-slip-in-skills-import-16398020178096808090
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix path traversal in skill imports#138
thirdeyenation wants to merge 1 commit into
mainfrom
sentinel/fix-zip-slip-in-skills-import-16398020178096808090

Conversation

@thirdeyenation
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Zip Slip (path traversal) vulnerability in helpers/skills_import.py when using extractall() to extract imported skills.
🎯 Impact: A malicious skill zip could contain file paths like ../../ allowing an attacker to overwrite arbitrary files on the system outside the designated import directory.
πŸ”§ Fix: Validated all entries in z.namelist() using is_relative_to() before allowing extractall() to proceed.
βœ… Verification: Review the code to ensure is_relative_to is used on resolved paths. Run test suite.


PR created automatically by Jules for task 16398020178096808090 started by @thirdeyenation

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant