π‘οΈ Sentinel: [CRITICAL] Fix path traversal in skill imports#138
π‘οΈ Sentinel: [CRITICAL] Fix path traversal in skill imports#138thirdeyenation wants to merge 1 commit into
Conversation
Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Zip Slip (path traversal) vulnerability in
helpers/skills_import.pywhen usingextractall()to extract imported skills.π― Impact: A malicious skill zip could contain file paths like
../../allowing an attacker to overwrite arbitrary files on the system outside the designated import directory.π§ Fix: Validated all entries in
z.namelist()usingis_relative_to()before allowingextractall()to proceed.β Verification: Review the code to ensure
is_relative_tois used on resolved paths. Run test suite.PR created automatically by Jules for task 16398020178096808090 started by @thirdeyenation