Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in File Download API#17

Open
thirdeyenation wants to merge 1 commit intomainfrom
sentinel/fix-path-traversal-download-api-17354534009067564141
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix Path Traversal in File Download API#17
thirdeyenation wants to merge 1 commit intomainfrom
sentinel/fix-path-traversal-download-api-17354534009067564141

Conversation

@thirdeyenation
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The DownloadFile endpoint in api/download_work_dir_file.py used file_info.get_file_info without properly validating the user-provided path parameter against the application's base directory limits.
🎯 Impact: An attacker could use ../ directory traversal payloads to download any readable file from the host operating system outside of the intended workspace directory (e.g., system configuration files or secrets).
πŸ”§ Fix: Added a definitive security boundary check using helpers.files.is_in_base_dir() after resolving the absolute path in the DownloadFile endpoint. If the resolved path escapes the base directory bounds, the API safely rejects the request with a ValueError.
βœ… Verification: Verified by running unit tests. The fix prevents directory traversal payloads like ../../../etc/passwd from successfully returning file contents. Recorded the learning in .jules/sentinel.md.


PR created automatically by Jules for task 17354534009067564141 started by @thirdeyenation

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant