⚡ Bolt: Replace DirtyJson.parse_string with try_parse#18
⚡ Bolt: Replace DirtyJson.parse_string with try_parse#18thirdeyenation wants to merge 1 commit intomainfrom
Conversation
Replaced `DirtyJson.parse_string` with `dirty_json.try_parse` across several plugins and `agent.py`. `dirty_json.try_parse` includes a fast path using the standard library's `json.loads` for valid JSON strings, which provides a significant performance improvement over always using `DirtyJson.parse_string`. * Moved inline `from helpers import dirty_json` imports to the module level in memory and browser agent plugins. * Modified `agent.py` to use `dirty_json.try_parse(stream)` in its message loop. * Removed deprecated and slower JSON parsing calls in memory consolidation and memorization extensions. Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced direct calls to
DirtyJson.parse_stringwithdirty_json.try_parseinagent.py,plugins/_memory/helpers/memory_consolidation.py,plugins/_memory/extensions/python/monologue_end/_51_memorize_solutions.py,plugins/_memory/extensions/python/monologue_end/_50_memorize_fragments.py, andplugins/_browser_agent/tools/browser_agent.py.🎯 Why:
dirty_json.try_parseincludes a fast path utilizing the standard library'sjson.loads, whereasDirtyJson.parse_stringmanually parses the JSON structure. This leads to a performance bottleneck as noted in.jules/bolt.md.📊 Impact: Measurable reduction in JSON parsing latency for the agent's monologue loop and memory systems. Tests verify standard fast-path parsing works.
🔬 Measurement: Verify using an isolated unit test or running normal agent interactions to ensure JSON responses are correctly parsed.
PR created automatically by Jules for task 4632539700692851375 started by @thirdeyenation