Fix C++ runtime loading issue by correcting js-lzma dependency and paths#145
Open
Rhinoatron wants to merge 5 commits intothoth-tech:mainfrom
Open
Fix C++ runtime loading issue by correcting js-lzma dependency and paths#145Rhinoatron wants to merge 5 commits intothoth-tech:mainfrom
Rhinoatron wants to merge 5 commits intothoth-tech:mainfrom
Conversation
Rhinoatron
had a problem deploying
to
static-site
GitHub Actions
Failure
Rhinoatron
had a problem deploying
to
static-site
GitHub Actions
Failure
Rhinoatron
had a problem deploying
to
static-site
GitHub Actions
Failure
Author
|
The C++ runtime issue has been resolved locally and the build now runs successfully. The remaining deploy failure appears to come from the base repository’s pull_request_target workflow, which is still attempting to download a preview artifact that is not available. Because pull_request_target uses the workflow definition from the base branch, workflow fixes made in this PR do not fully apply until this request has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the C++ environment remains stuck on "Loading..." due to missing js-lzma assets and incorrect file paths.
Root cause:
js-lzma dependency not present after cloning
outdated references to external/js-lzma paths
Changes:
updated all references from external/js-lzma to js-lzma
ensured required dependency is available locally
verified C++ environment initialises successfully
This fix restores full functionality of the C++ runtime environment.