Skip to content

Investigate dependencies - visualisations.coffee#450

Open
WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
WaelAlahamdi:quality/migrate-visualisation-service
Open

Investigate dependencies - visualisations.coffee#450
WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
WaelAlahamdi:quality/migrate-visualisation-service

Conversation

@WaelAlahamdi
Copy link
Copy Markdown

Description

This pull request moves the shared visualisation logic from the AngularJS CoffeeScript factory into a new TypeScript service.

The change introduces a new visualisation.service.ts file to hold the shared chart creation defaults, config setup, analytics tracking, and refresh logic. The service is exposed to the hybrid Angular/AngularJS application through downgradeInjectable, and visualisations.coffee has been updated to act as a compatibility wrapper so existing CoffeeScript visualisation consumers can continue to work without further changes.

This change supports the ongoing migration of the project toward Angular 17 and TypeScript while preserving the current behaviour of the visualisation components.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The change was tested manually in the local development environment.

Manual testing performed

  1. Started the application locally
  2. Opened the student dashboard
  3. Opened the staff dashboard
  4. Verified that the Progress Burndown chart still renders correctly
  5. Verified that the Task Statuses chart still renders correctly
  6. Confirmed that the visualisation behaviour remained unchanged after the refactor

Additional checks

  • Ran npx tsc -p tsconfig.json --noEmit successfully

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from two members of the Frontend Migration team on the Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant