Investigate dependencies - visualisations.coffee#450
Open
WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
Open
Investigate dependencies - visualisations.coffee#450WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request moves the shared visualisation logic from the AngularJS CoffeeScript factory into a new TypeScript service.
The change introduces a new
visualisation.service.tsfile to hold the shared chart creation defaults, config setup, analytics tracking, and refresh logic. The service is exposed to the hybrid Angular/AngularJS application throughdowngradeInjectable, andvisualisations.coffeehas been updated to act as a compatibility wrapper so existing CoffeeScript visualisation consumers can continue to work without further changes.This change supports the ongoing migration of the project toward Angular 17 and TypeScript while preserving the current behaviour of the visualisation components.
Type of change
How Has This Been Tested?
The change was tested manually in the local development environment.
Manual testing performed
Progress Burndownchart still renders correctlyTask Statuseschart still renders correctlyAdditional checks
npx tsc -p tsconfig.json --noEmitsuccessfullyTesting Checklist:
Checklist: