Migrate/root controller#451
Open
Thirus224849242 wants to merge 841 commits intothoth-tech:developmentfrom
Open
Migrate/root controller#451Thirus224849242 wants to merge 841 commits intothoth-tech:developmentfrom
Thirus224849242 wants to merge 841 commits intothoth-tech:developmentfrom
Conversation
…ssessed feat: task assessment counts csv
feat: task prerequisites
…terceptor refactor: add automatic refresh token handling and request retry
* feat: display available storage for docker images * refactor: hide available storage if disabled
- Increase poll delay and failure threshold (5) to improve blue-green Caddy switchover buffer
* refactor: remove ui to add tutorial with no stream * refactor: improve tutorial ui * refactor: add ui to show no tutorials added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
root-controllerfrom CoffeeScript and AngularJS to TypeScript and Angular as part of the ongoing Doubtfire migration effort.The original
AppCtrlcontroller was empty with only aGlobalStateServiceinjection and no implementation. The newRootControllerComponentmaintains this behaviour while following the Angular component pattern.Changes made:
root-controller.component.tsas the Angular replacement forroot-controller.coffeeRootControllerComponentindoubtfire-angular.module.tsdeclarationsRootControllerComponentindoubtfire-angularjs.module.tsusingdowngradeComponentto maintain hybrid app compatibilityAppCtrlcontroller indoubtfire-angularjs.module.tsto maintain compatibility withng-controller="AppCtrl"inindex.htmldoubtfire.config.root-controllerfromconfig.coffeeroot-controller.coffeeFixes # (issue)
Type of change
How Has This Been Tested?
The app was loaded and tested locally after each change to ensure nothing broke. The
ng-controller="AppCtrl"inindex.htmlcontinues to work correctly via thedowngradeComponentbridge.Testing Checklist:
Checklist: