need to test

.claude/settings.json

@@ -0,0 +1,5 @@
+{
+  "enabledPlugins": {
+    "superpowers@superpowers-marketplace": true
+  }
+}

.github/workflows/ci.yml

@@ -87,6 +87,31 @@ jobs:
         with:
           command: check advisories licenses bans sources
 
+  # D-83 #4: cargo-machete catches unused workspace deps. Not branch-protection required.
+  unused-deps:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: bnjbvr/cargo-machete@v0.9.2
+
+  # POLISH-05 automated half: real tmux 3.4+ DCS round-trip. Not branch-protection required.
+  # continue-on-error: clipboard passthrough requires an interactive outer terminal;
+  # detached CI sessions have nowhere to DCS-pass-through to, so pbpaste is always empty.
+  tmux-smoke:
+    needs: [test]
+    runs-on: macos-14
+    continue-on-error: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: dtolnay/rust-toolchain@1.88.0
+        with:
+          targets: aarch64-apple-darwin
+      - uses: Swatinem/rust-cache@v2
+        with:
+          shared-key: ci-tmux-smoke
+      - run: brew install tmux
+      - run: cargo test -p vector-term --test osc52_tmux -- --ignored
+
   build-arm64:
     if: github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main')
     needs: [lint, test, deny]

.gitignore

@@ -6,3 +6,4 @@ crates/vector-app/resources/icon.iconset/
 crates/vector-app/resources/icon.icns
 artifacts/
 RELEASE_NOTES.md
+.claude/worktrees/

.planning/PROJECT.md

@@ -14,16 +14,17 @@ Vector is a native macOS terminal — written in Rust, GPU-accelerated — with
 
 - [x] CI build pipeline that produces installable `.dmg` artifacts (Phase 1 — operationally validated 2026-05-11; CI tip + tagged v2026.5.10 Universal DMG both confirmed launching on macOS Sequoia)
 - [x] xterm-compatible terminal core (parser + grid + scrollback) suitable as a daily-driver local shell (Phase 2 — `vector-headless` proxy ran vim/tmux/htop/less cleanly on 2026-05-11; CORE-01..06 backed by 53 passing tests, conformance suite 0.326s vs 1s D-37 budget)
+- [x] GPU-accelerated terminal rendering on Mac (Metal via wgpu) — Phase 3 operationally validated 2026-05-11: wgpu Metal `Surface<'static>` with PresentMode::Fifo, crossfont + dual-atlas (mono RGBA8 + color emoji) with bounded LRU, Compositor reading `Term::damage()` with truecolor/256-color SGR + per-cell selection bit + block cursor, xterm keymap + bracketed paste + click-drag selection + scroll-wheel scrollback, PTY-burst coalescing (8 ms), LPM 30 fps cap, DPR atlas invalidation, debounced resize, first-paint timing gate. RENDER-01..05 + WIN-01 all verified. Workspace: 175 passing / 0 failed / 0 ignored. 9-item manual smoke matrix signed off (vim, large.log fps, idle <1% CPU, Retina swap, selection, Cmd-V paste, ProMotion, LPM, Cmd-Ctrl-F fullscreen).
+- [x] Tabs and splits (horizontal/vertical), multiple sessions per window — Phase 4 operationally validated 2026-05-12 after Plan 04-06 gap closure. `vector-mux` Mux singleton + Window/Tab/PaneNode tree + split tree with directional focus + resize-nudge + close-cascade; per-pane PTY actors via `tokio::task::JoinSet` with per-pane `CoalesceBuffer`/`frame_tick`; foreground process name polling (D-57) + cwd inheritance via `proc_pidinfo` (D-63/D-64); native NSWindow tab groups via winit `set_tabbing_identifier` + objc2-app-kit (D-56) routing one `NSWindow` per Tab; per-pane Compositor map in `AppWindow` with chained `LoadOp::Clear`/`LoadOp::Load` per leaf and visible D-66 active-pane border; 14 mux keymap entries (Cmd-Opt-Arrow, Cmd-Shift-Arrow, Cmd-T/D/Shift-D/W/Shift-]/Shift-[) that never reach the PTY. WIN-02/03/04 all validated. Workspace: 231 passing / 0 failed / 3 ignored. D-38 invariant intact (zero diff in `vector-mux/src/{domain,transport}.rs`). 9-item smoke matrix signed off (multi-pane visible render, per-pane `tput cols` after SIGWINCH, visible D-66 border, Cmd-T tab group, Cmd-W cascade, cwd inheritance, idle <1% CPU, zsh↔vim title flip, DPR re-rasterize across panes).
 
 ### Active
 
+- [x] Polish local terminal to daily-driver quality — config hot-reload, theme engine, search bar, profile picker, OSC 52 clipboard, IME, Secure Keyboard Entry, hyperlinks, OSC 7 cwd, Cmd-N window spawning — Phase 5 operationally validated 2026-05-14: all 8 POLISH requirements verified; 16/16 plans complete; 332 tests passing; 10-item smoke matrix 10/10 approved.
+- [x] GitHub OAuth sign-in flow (device-code) with token caching in macOS Keychain — Phase 6 code-complete 2026-05-14: AUTH-01/02/03 fully wired (device-flow + Keychain via vector-secrets + 401 silent-refresh chain); AppKit `AuthDeviceFlowModal` NSPanel + `Sign in with GitHub` menu item + Cmd-Shift-G; 363 workspace tests pass; Pitfall-14 arch-lint enforces zero-Debug-on-token discipline; token-leak grep 0 hits. Human smoke matrix (11 items) tracked in `06-HUMAN-UAT.md` — drive via `/gsd:verify-work 6`.
+- [x] List / pick GitHub Codespaces from the UI (no `gh` CLI required) — Phase 6 code-complete 2026-05-14: CS-01/02/03 fully wired (`CodespacesPickerModal` NSPanel + `CodespacesClient` REST + start/409-swallow/poll + Save-as-profile via `vector-config::writer::append_codespace_profile`). `Connect` placeholder toast points at Phase 7. Connect/transport stays in Phase 7 (Dev Tunnels + gRPC + russh).
 - [ ] Native macOS app distributed as an unsigned `.dmg` (right-click → Open), Universal binary
-- [ ] GPU-accelerated terminal rendering on Mac (Metal via wgpu) — performance comparable to Alacritty/WezTerm/ghostty
-- [ ] Tabs and splits (horizontal/vertical), multiple sessions per window
 - [ ] Session persistence + transparent reconnect — wifi drop should not lose Codespace state
 - [ ] tmux pass-through that "just works" — no double-multiplex visual glitches when remote tmux is running
-- [ ] GitHub OAuth sign-in flow (device-code or browser callback) with token caching
-- [ ] List / pick / connect to existing GitHub Codespaces from the UI (no `gh` CLI required)
 - [ ] Connect to a remote machine running `code tunnel` (Microsoft Dev Tunnels) using GitHub auth
 - [ ] Saved profiles (`my-cs-frontend`, `my-corp-box`, etc.) for one-click reconnect
 - [ ] Themes, fonts, ligatures (table-stakes terminal eye-candy)
@@ -99,4 +100,6 @@ This document evolves at phase transitions and milestone boundaries.
 4. Update Context with current state
 
 ---
-*Last updated: 2026-05-11 after Phase 2 complete — `vector-headless` pass-through proxy ships with locked D-38 `PtyTransport`/`Domain` trait shapes ready for Phases 4/7/8/9 to plug into. `vector-term` (alacritty_terminal 0.26 wrapper, 26 conformance tests in 0.326s), `vector-pty` (portable-pty 0.9 + tokio blocking-thread bridge), `vector-mux` (LocalDomain full impl + Codespace/DevTunnel `unimplemented!()` stubs), and the binary itself all green; user-approved smoke matrix (echo, vim, tmux, htop, less) passed. CORE-01..06 satisfied.*
+*Last updated: 2026-05-14 after Phase 6 code-complete — GitHub auth + Codespaces picker shipped. `vector-codespaces` crate: OAuth Device Flow (RFC 8628) + Keychain-backed `TokenStore` + `CodespacesClient` with raw octocrab `_get`/`_post` + 401 silent-refresh chain. `vector-config::writer::append_codespace_profile` + `derive_profile_name` (toml_edit round-trip + atomic rename matching Plan 05-04 watcher). `vector-app`: `AuthDeviceFlowModal` NSPanel (440x280, NSFloatingWindowLevel, clipboard save/restore per Pitfall 7), `CodespacesPickerModal` NSPanel (640x480, LoadState, per-row poll tasks), `auth_actor` + `codespaces_actor` tokio drivers, 10 new UserEvent variants, 3 menu items (Sign in / Sign out / Codespaces…), Cmd-Shift-G keymap, D-84 sign-in chokepoint, Pitfall-14 arch-lint (manual Debug on token-bearing structs, no tracing macros near tokens). Workspace tests 363 passing / 0 failed / 5 ignored (manual UAT placeholders). Token-leak audit (`gho_/ghu_/ghp_`) returns 0 hits. AUTH-01/02/03 + CS-01/02/03 all code-complete; 11-item manual smoke matrix tracked in `06-HUMAN-UAT.md` for `/gsd:verify-work 6`. Phase 7 (Dev Tunnels + gRPC SSH transport via russh) is next.*
+
+*Previously updated: 2026-05-12 after Phase 4 complete — tabs + splits shipped. `vector-mux` adds a Mux singleton + Window/Tab/PaneNode tree + split tree with directional focus, resize-nudge, and close-cascade; per-pane PTY actors via `tokio::task::JoinSet` with per-pane `CoalesceBuffer`/`frame_tick`; foreground process name polling (D-57) + cwd inheritance via `proc_pidinfo` (D-63/D-64); native NSWindow tab groups via winit `set_tabbing_identifier` + objc2-app-kit (D-56) with one `NSWindow` per Tab; per-pane Compositor map in `AppWindow` with chained `LoadOp::Clear`/`LoadOp::Load` and visible D-66 active-pane border; 14 mux keymap entries (Cmd-Opt-Arrow, Cmd-Shift-Arrow, Cmd-T/D/Shift-D/W/Shift-]/Shift-[) that never reach the PTY. Plan 04-06 closed three gaps (smoke #3 multi-pane visible render, #4 per-pane `tput cols` after SIGWINCH, #8 visible D-66 border) by extending `AppWindow` with `compositors: HashMap<PaneId, Compositor>` + `active_pane_id` and routing per-pane SIGWINCH through `Mux::resize_window` → `PtyActorRouter::send_resize`. Workspace tests 231 passing / 0 failed / 3 ignored; D-38 byte-identical invariant intact (zero diff in `vector-mux/src/{domain,transport}.rs`); arch-lint count 16; 9-item manual smoke matrix signed off. WIN-02 + WIN-03 + WIN-04 all validated.*

.planning/REQUIREMENTS.md

@@ -26,39 +26,39 @@ Requirements for initial release. Each maps to roadmap phases. Categories are de
 
 ### Rendering
 
-- [ ] **RENDER-01**: GPU-accelerated rendering targets the Metal backend of `wgpu`, with damage-tracked redraws (only dirty rows shaped/uploaded)
-- [ ] **RENDER-02**: Sustained `cat large.log` output reaches at least 60 fps on Apple Silicon at 1080p; ProMotion (120 Hz) is detected and honored
-- [ ] **RENDER-03**: Idle CPU usage stays below 1% on Apple Silicon (no redraw when nothing is dirty)
-- [ ] **RENDER-04**: Glyph atlas separates monochrome and emoji textures, evicts via bounded LRU, and survives mid-session scale changes (Retina ↔ external monitor)
-- [ ] **RENDER-05**: Cursor and selection overlays render correctly under the live text grid
+- [x] **RENDER-01**: GPU-accelerated rendering targets the Metal backend of `wgpu`, with damage-tracked redraws (only dirty rows shaped/uploaded)
+- [x] **RENDER-02**: Sustained `cat large.log` output reaches at least 60 fps on Apple Silicon at 1080p; ProMotion (120 Hz) is detected and honored
+- [x] **RENDER-03**: Idle CPU usage stays below 1% on Apple Silicon (no redraw when nothing is dirty)
+- [x] **RENDER-04**: Glyph atlas separates monochrome and emoji textures, evicts via bounded LRU, and survives mid-session scale changes (Retina ↔ external monitor)
+- [x] **RENDER-05**: Cursor and selection overlays render correctly under the live text grid
 
 ### Window & Mux
 
-- [ ] **WIN-01**: Native macOS AppKit window with title bar, fullscreen, and standard window-control buttons
-- [ ] **WIN-02**: Tabs — open new tab (Cmd-T), cycle (Cmd-Shift-]/[), close (Cmd-W). Native `NSWindowTabbingMode` or visually equivalent custom bar.
-- [ ] **WIN-03**: Splits — horizontal (Cmd-D) and vertical (Cmd-Shift-D) splits within a tab, with focus routing and per-pane resize
-- [ ] **WIN-04**: A `Domain / Pane / PtyTransport` abstraction (WezTerm-style) is the only seam between terminal model and transport — local, SSH, and tunnel transports all implement the same trait
+- [x] **WIN-01**: Native macOS AppKit window with title bar, fullscreen, and standard window-control buttons
+- [x] **WIN-02**: Tabs — open new tab (Cmd-T), cycle (Cmd-Shift-]/[), close (Cmd-W). Native `NSWindowTabbingMode` or visually equivalent custom bar.
+- [x] **WIN-03**: Splits — horizontal (Cmd-D) and vertical (Cmd-Shift-D) splits within a tab, with focus routing and per-pane resize
+- [x] **WIN-04**: A `Domain / Pane / PtyTransport` abstraction (WezTerm-style) is the only seam between terminal model and transport — local, SSH, and tunnel transports all implement the same trait
 - [x] **WIN-05**: `winit::EventLoop` runs on the main thread; `tokio` runs on background threads; cross-thread signaling goes through `EventLoopProxy::send_event` (no `block_on` on main, no shared mutex held across `await`)
 
 ### Polish (Local Daily-Driver)
 
-- [ ] **POLISH-01**: TOML configuration with hot-reload via `notify` (FSEvents); profile inheritance (`[default]` + named overrides) without a scripting language
-- [ ] **POLISH-02**: Bring-your-own-font from system or `~/Library/Fonts`; opt-in ligatures; Nerd Font glyphs render correctly
-- [ ] **POLISH-03**: Built-in light + dark themes plus an importer for `.itermcolors` palettes
-- [ ] **POLISH-04**: OSC 7 (cwd), OSC 8 (hyperlinks), OSC 10/11/12 (color queries), and OSC 133 (semantic prompt marks) are implemented
-- [ ] **POLISH-05**: OSC 52 clipboard copy works in both raw and DCS-wrapped forms (tmux pass-through compatibility)
-- [ ] **POLISH-06**: Scrollback regex search with match highlighting and next/prev navigation
-- [ ] **POLISH-07**: Profiles — saved targets named `local`, `codespace`, `dev_tunnel` with per-profile env, theme, tint, and startup command
-- [ ] **POLISH-08**: Secure Keyboard Entry toggle and basic IME composition display via `NSTextInputClient` (no candidate window UI; full IME is v2)
+- [x] **POLISH-01**: TOML configuration with hot-reload via `notify` (FSEvents); profile inheritance (`[default]` + named overrides) without a scripting language
+- [x] **POLISH-02**: Bring-your-own-font from system or `~/Library/Fonts`; opt-in ligatures; Nerd Font glyphs render correctly
+- [x] **POLISH-03**: Built-in light + dark themes plus an importer for `.itermcolors` palettes
+- [x] **POLISH-04**: OSC 7 (cwd), OSC 8 (hyperlinks), OSC 10/11/12 (color queries), and OSC 133 (semantic prompt marks) are implemented
+- [x] **POLISH-05**: OSC 52 clipboard copy works in both raw and DCS-wrapped forms (tmux pass-through compatibility)
+- [x] **POLISH-06**: Scrollback regex search with match highlighting and next/prev navigation
+- [x] **POLISH-07**: Profiles — saved targets named `local`, `codespace`, `dev_tunnel` with per-profile env, theme, tint, and startup command
+- [x] **POLISH-08**: Secure Keyboard Entry toggle and basic IME composition display via `NSTextInputClient` (no candidate window UI; full IME is v2)
 
 ### GitHub Auth & Codespaces Picker
 
-- [ ] **AUTH-01**: GitHub OAuth Device Flow (RFC 8628) sign-in works from inside the app — no browser plugin, no PAT pasting
-- [ ] **AUTH-02**: OAuth tokens are stored in macOS Keychain via `keyring 4.0`; never written to disk in plaintext, never logged
-- [ ] **AUTH-03**: Token refresh is handled silently; expired tokens trigger a re-auth prompt rather than silent failure
-- [ ] **CS-01**: After sign-in, a Codespaces picker lists every codespace for the user with state (Available / Shutdown / Starting), repository name, branch, and last-used time
-- [ ] **CS-02**: Selecting a Shutdown codespace from the picker triggers `POST /start`, polls until Available (with 409 swallowed), then connects
-- [ ] **CS-03**: A picked codespace can be saved as a one-click profile that survives app restart
+- [x] **AUTH-01**: GitHub OAuth Device Flow (RFC 8628) sign-in works from inside the app — no browser plugin, no PAT pasting _(Wave-0 scaffolded — test stubs + manual-Debug GitHubAuth stub landed in Plan 06-01; real impl lands in Plan 06-02)_
+- [x] **AUTH-02**: OAuth tokens are stored in macOS Keychain via `keyring 4.0`; never written to disk in plaintext, never logged _(Wave-0 scaffolded — TokenStore stub + GITHUB_REFRESH_ACCOUNT const + Pitfall-14 arch-lint landed in Plan 06-01; real impl lands in Plan 06-02)_
+- [x] **AUTH-03**: Token refresh is handled silently; expired tokens trigger a re-auth prompt rather than silent failure _(Wave-0 scaffolded — auth_refresh.rs test stubs landed in Plan 06-01; real impl lands in Plan 06-03)_
+- [x] **CS-01**: After sign-in, a Codespaces picker lists every codespace for the user with state (Available / Shutdown / Starting), repository name, branch, and last-used time _(Wave-0 scaffolded — CodespacesClient stub + Codespace model + list_codespaces.json fixture + codespaces_rest.rs test stubs landed in Plan 06-01; real impl lands in Plan 06-03)_
+- [x] **CS-02**: Selecting a Shutdown codespace from the picker triggers `POST /start`, polls until Available (with 409 swallowed), then connects _(Wave-0 scaffolded — start/poll test stubs landed in Plan 06-01; real impl lands in Plan 06-03)_
+- [x] **CS-03**: A picked codespace can be saved as a one-click profile that survives app restart _(Wave-0 scaffolded — vector-config::writer module + profile_writer.rs test stubs landed in Plan 06-01; real impl lands in Plan 06-04)_
 
 ### Codespaces SSH Connect
 
@@ -163,29 +163,29 @@ Every v1 requirement maps to exactly one phase. No orphans, no duplicates.
 | CORE-04 | Phase 2 | Complete |
 | CORE-05 | Phase 2 | Complete |
 | CORE-06 | Phase 2 | Complete |
-| RENDER-01 | Phase 3 | Pending |
-| RENDER-02 | Phase 3 | Pending |
-| RENDER-03 | Phase 3 | Pending |
-| RENDER-04 | Phase 3 | Pending |
-| RENDER-05 | Phase 3 | Pending |
-| WIN-01 | Phase 3 | Pending |
-| WIN-02 | Phase 4 | Pending |
-| WIN-03 | Phase 4 | Pending |
-| WIN-04 | Phase 4 | Pending |
-| POLISH-01 | Phase 5 | Pending |
-| POLISH-02 | Phase 5 | Pending |
-| POLISH-03 | Phase 5 | Pending |
-| POLISH-04 | Phase 5 | Pending |
-| POLISH-05 | Phase 5 | Pending |
-| POLISH-06 | Phase 5 | Pending |
-| POLISH-07 | Phase 5 | Pending |
-| POLISH-08 | Phase 5 | Pending |
-| AUTH-01 | Phase 6 | Pending |
-| AUTH-02 | Phase 6 | Pending |
-| AUTH-03 | Phase 6 | Pending |
-| CS-01 | Phase 6 | Pending |
-| CS-02 | Phase 6 | Pending |
-| CS-03 | Phase 6 | Pending |
+| RENDER-01 | Phase 3 | Complete |
+| RENDER-02 | Phase 3 | Complete |
+| RENDER-03 | Phase 3 | Complete |
+| RENDER-04 | Phase 3 | Complete |
+| RENDER-05 | Phase 3 | Complete |
+| WIN-01 | Phase 3 | Complete |
+| WIN-02 | Phase 4 | Complete |
+| WIN-03 | Phase 4 | Complete |
+| WIN-04 | Phase 4 | Complete |
+| POLISH-01 | Phase 5 | Complete |
+| POLISH-02 | Phase 5 | Complete |
+| POLISH-03 | Phase 5 | Complete |
+| POLISH-04 | Phase 5 | Complete |
+| POLISH-05 | Phase 5 | Complete |
+| POLISH-06 | Phase 5 | Complete |
+| POLISH-07 | Phase 5 | Complete |
+| POLISH-08 | Phase 5 | Complete |
+| AUTH-01 | Phase 6 | Complete |
+| AUTH-02 | Phase 6 | Complete |
+| AUTH-03 | Phase 6 | Complete |
+| CS-01 | Phase 6 | Complete |
+| CS-02 | Phase 6 | Complete |
+| CS-03 | Phase 6 | Complete |
 | CS-04 | Phase 7 | Pending |
 | CS-05 | Phase 7 | Pending |
 | CS-06 | Phase 7 | Pending |
@@ -211,3 +211,4 @@ Every v1 requirement maps to exactly one phase. No orphans, no duplicates.
 ---
 *Requirements defined: 2026-05-10*
 *Last updated: 2026-05-10 — Plan 01-06 closed: BUILD-04 (tagged-release half) and BUILD-05 (xattr in README) complete in commits 4dd0c4e + 75b77b1; BUILD-02 / BUILD-04 retain pending-real-CI-run / pending-real-tagged-release caveat per 01-05 + 01-06 Outstanding Verification Debt blocks*
+*Last updated: 2026-05-12 — Plan 04-06 closed: WIN-02 + WIN-03 complete after smoke matrix re-run (items #3, #4, #8 PASS).*