Skip to content

Skip TestS3Arn in all tests run #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuanyu66 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip TestS3Arn in all tests run #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320276b
Skip TestS3Arn in all tests run
xuanyu66 Jun 1, 2026
73094e9
Uncomment TestZeroDateImport function implementation
xuanyu66 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/import-scene-test-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
run: |
if [ -z ${{ github.event.inputs.testCase }} ]; then
echo "Running all tests"
go run gotest.tools/gotestsum@latest --format standard-verbose -- sceneTest/import/* -timeout 30m -args --cid 10987985172501194742 --config "${{ secrets.TEST_CONFIG_DEV }}" --test.timeout 30m
go run gotest.tools/gotestsum@latest --format standard-verbose -- sceneTest/import/* -timeout 30m -args --cid 10987985172501194742 --config "${{ secrets.TEST_CONFIG_DEV }}" --test.timeout 30m --test.skip "TestS3Arn"
else
echo "Running test ${{ github.event.inputs.testCase }}"
go run gotest.tools/gotestsum@latest --format standard-verbose -- sceneTest/import/* -args --cid 10987985172501194742 --config "${{ secrets.TEST_CONFIG_DEV }}" --test.run ${{ github.event.inputs.testCase }}
Expand Down
72 changes: 36 additions & 36 deletions sceneTest/import/import_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,39 +180,39 @@ func TestSchemaColumnNumberMismatchedImport(t *testing.T) {
}

// TestZeroDateImport verifies zero date strings can be imported without errors
// func TestZeroDateImport(t *testing.T) {
// ctx := context.Background()

// if _, err := db.ExecContext(ctx, "DROP TABLE IF EXISTS `test`.`zero_date`"); err != nil {
// t.Fatalf("Failed to drop zero date import table: %v", err)
// }

// cfg := config.LoadConfig()

// importOptions := imp.ImportOptions{
// FileType: imp.IMPORTFILETYPEENUM_CSV,
// CsvFormat: &imp.CSVFormat{
// Separator: pointer.ToString(";"),
// },
// }

// s3Source := &imp.S3Source{
// Uri: cfg.Import.S3.ZeroDateURI,
// AuthType: imp.IMPORTS3AUTHTYPEENUM_ACCESS_KEY,
// AccessKey: &imp.S3SourceAccessKey{
// Id: cfg.S3.AccessKeyID,
// Secret: cfg.S3.SecretAccessKey,
// },
// }

// importID, err := createS3Import(ctx, importOptions, s3Source)
// if err != nil {
// t.Fatalf("Failed to create zero date import: %v", err)
// }

// if err := waitImport(ctx, importID); err != nil {
// t.Fatalf("Zero date import failed, importId: %s, error: %v", importID, err)
// }

// t.Log("Zero date import completed successfully")
// }
func TestZeroDateImport(t *testing.T) {
ctx := context.Background()

if _, err := db.ExecContext(ctx, "DROP TABLE IF EXISTS `test`.`zero_date`"); err != nil {
t.Fatalf("Failed to drop zero date import table: %v", err)
}

cfg := config.LoadConfig()

importOptions := imp.ImportOptions{
FileType: imp.IMPORTFILETYPEENUM_CSV,
CsvFormat: &imp.CSVFormat{
Separator: pointer.ToString(";"),
},
}

s3Source := &imp.S3Source{
Uri: cfg.Import.S3.ZeroDateURI,
AuthType: imp.IMPORTS3AUTHTYPEENUM_ACCESS_KEY,
AccessKey: &imp.S3SourceAccessKey{
Id: cfg.S3.AccessKeyID,
Secret: cfg.S3.SecretAccessKey,
},
}

importID, err := createS3Import(ctx, importOptions, s3Source)
if err != nil {
t.Fatalf("Failed to create zero date import: %v", err)
}

if err := waitImport(ctx, importID); err != nil {
t.Fatalf("Zero date import failed, importId: %s, error: %v", importID, err)
}

t.Log("Zero date import completed successfully")
}
Loading