Updates parameter handling#7
Open
edgararuiz wants to merge 1 commit into
Open
Conversation
Updates the tuning parameter handling now that they have been moved to dials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed 11 local parameter definitions (
R/param_*.R) now provided by dials:bottleneck_units,dropout_attn,dropout_embedding,num_attn_blocks,num_attn_feat,num_attn_heads,num_embedding,penalty_average,penalty_type,resid_at,step_rate— along with their tests and man pages. Verified field-by-field that the dials definitions are identical (type / range /inclusive/trans/values).Repointed
set_model_arg()registrations frompkg = "tabular"→pkg = "dials"acrossauto_int.R,tabular_rln.R, andtabular_resnet.R.Fixed a pre-existing bug:
resid_athad noset_model_arg()registration, so it was silently dropped before reachingbrulee and was invisible to
tune(). Added the registration, mapping the parsnip argresid_at→ brulee's engine argresidual_at.Re-pointed roxygen autolinks in
tabular_rln.Rto[dials::penalty_average()]/[dials::step_rate()]to avoid dangling-link check warnings.DESCRIPTION:
dials (>= 1.4.3.9000), dropped now-unusedscales, addedbrulee (>= 0.7.0)to Suggests (all four engine functions tabular uses are new in brulee 0.7.0), and addedRemotes: tidymodels/brulee, tidymodels/dialssince both are dev-only for now.