Skip to content

Support V2 TSO microservice discovery#540

Draft
disksing wants to merge 1 commit into
masterfrom
task27/tso-microservice-v2
Draft

Support V2 TSO microservice discovery#540
disksing wants to merge 1 commit into
masterfrom
task27/tso-microservice-v2

Conversation

@disksing

Copy link
Copy Markdown

Summary

  • detect PD API service mode via GetClusterInfo
  • discover TSO keyspace groups through tsopb.FindGroupByKeyspaceID
  • open direct tsopb.TSO/Tso streams and cache timestamp oracles per keyspace id
  • keep PD TSO as fallback for non-microservice deployments
  • pass V2 keyspace ids into transactional timestamp paths

Validation

  • cargo fmt
  • cargo +nightly-2026-01-30 check
  • cargo +nightly-2026-01-30 test --lib (58 tests)

Note: the pinned 1.84.1 toolchain did not reach project code in this local environment because fresh dependency resolution selected crates requiring edition2024; the repo ignores Cargo.lock.

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. labels Jun 17, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lykxsassinator for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3498118a-6fc3-43c1-9b67-aa483e588356

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task27/tso-microservice-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant