Check if the strings 'for' and 'while' in function#146
Open
koddsson wants to merge 1 commit intotimoxley:masterfrom
Open
Check if the strings 'for' and 'while' in function#146koddsson wants to merge 1 commit intotimoxley:masterfrom
koddsson wants to merge 1 commit intotimoxley:masterfrom
Conversation
Owner
|
Ideally we'd parse their solution into an AST and check for loop constructs that way… but this perhaps solves it the most simple way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119 by checking the given function for the strings "while" or "for". It has the obvious drawback of failing if the mere string is present.
Not sure if this is the best solution but I thought at least it would get a dialog started on how to fix this issue.