Make basic_filter copy a little clearer#147
Open
clamey wants to merge 1 commit intotimoxley:masterfrom
Open
Conversation
timoxley
reviewed
Nov 15, 2016
Owner
timoxley
left a comment
timoxley
left a comment
There was a problem hiding this comment.
Confusion perhaps comes from the Example not being clear about that being output, not input.
Perhaps it simply needs explicit "example input" and "example output".
| { message: 'Mollit ea labore do laboris nostrud proident ullamco.' }, | ||
| { message: 'Laboris excepteur aliquip ullamco culpa.' }, | ||
| { message: 'Culpa minim proident dolor ipsum ullamco est qui non aute aliquip excepteur sunt.' }, | ||
| { message: 'Cupidatat duis sit aute pariatur amet sit excepteur cupidatat.' } ] |
Owner
There was a problem hiding this comment.
This is incorrect output though, the solution expects an array of strings, not an array of objects.
| Use Array#filter to write a function called `getShortMessages`. | ||
|
|
||
| `getShortMessages` takes an array of objects with '.message' properties and returns an array of messages that are *less than < 50 characters long*. | ||
| `getShortMessages` takes an array of objects with 'message' properties and returns an array of messages that are *less than < 50 characters long*. |
Owner
There was a problem hiding this comment.
If this said "an array of messages as strings" I'd agree that this is clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.