Remove unnecessary arguments#158
Open
gs20060101 wants to merge 1 commit intotimoxley:masterfrom
gs20060101:patch-1
Open
Remove unnecessary arguments#158gs20060101 wants to merge 1 commit intotimoxley:masterfrom gs20060101:patch-1
gs20060101 wants to merge 1 commit intotimoxley:masterfrom
gs20060101:patch-1
Conversation
The function "fn" is a user-supplied function that would not take "index" and "arr" arguments.
|
the callback function supplied to Array.prototype.map() takes three arguments: currentValue: The current element being processed in the array. the tests pass even if you leave the second two out (see below) but I think the official solution is more complete with them module.exports = function map(arr, fn) {
return arr.reduce(function(acc, item, index) {
acc[index] = (fn(item))
return acc
}, [])
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function "fn" is a user-supplied function that would not take "index" and "arr" arguments.