Open
Conversation
justsml
commented
May 14, 2017
| load = Promise.promisify(load); // could be eliminated | ||
| return Promise.resolve(userIds) | ||
| .map(id => load(id)) | ||
| .then(done); |
Author
There was a problem hiding this comment.
By calling done with the Promise chain's native .then get a more backwards compatible pattern as a bonus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't expect this to be merged as is; however I was hoping to discuss how to update/amend these examples.
Is there any way you would support multiple
solution.jsfiles, something likesolution.promise.jsorsolution.flow.js,solution.compose.js,solution.reduce.jsor whatever the pattern uses."Why add Promises?"
I'm using them as a chaining construct. I know there are ways to do this without Promises. I'm using Bluebird in a related project I'm working on
Escape from Callback Mountain- see a pattern comparisons on the wiki -I'm using a
Functional Promisespattern to remove: 2 side-effects, an extra logical branching and mutable array usage. Also about ~50% lines of code removed.It would require a few changes to runner.