Add support for the cores scheduler for esp32s3#5358
Draft
hamstah wants to merge 1 commit into
Draft
Conversation
deadprogram
reviewed
Jun 6, 2026
| // https://0x04.net/~mwk/doc/xtensa.pdf | ||
|
|
||
| import ( | ||
| _ "unsafe" |
Member
There was a problem hiding this comment.
Adding "unsafe" again is not correct.
deadprogram
reviewed
Jun 6, 2026
| sleepingCore = 0xff | ||
| } | ||
|
|
||
| func interruptSleepTicksMulticore(wakeup timeUnit) { |
Member
There was a problem hiding this comment.
This function is supposed to interrupt sleepTicks but does not, so time.Sleep() would probably hang.
deadprogram
reviewed
Jun 6, 2026
| schedulerWake() | ||
| } | ||
|
|
||
| func schedulerUnlockAndWait() { |
Member
There was a problem hiding this comment.
I think this would introduce some unwanted latency.
deadprogram
reviewed
Jun 6, 2026
| } | ||
| } | ||
|
|
||
| func gcInterruptHandler(hartID uint32) { |
Member
There was a problem hiding this comment.
Perhaps use GC core signaling here to improve efficiency.
deadprogram
reviewed
Jun 6, 2026
| memcpy = 0x400011f4; | ||
| memmove = 0x40001200; | ||
| memcmp = 0x4000120c; | ||
| ets_set_appcpu_boot_addr = 0x40000720; |
Member
There was a problem hiding this comment.
There are some other ets_ addresses in this file, this probably should be next to one of them?
Member
|
Hello @hamstah thanks for working this and sorry for the delay in reviewing. I have made a few comments. Also you should rebase this PR against the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is an attempt to support the cores scheduler for the esp32s3.
Disclaimer:
See the longer context for the PR in #5353
Thanks