[feature] added flash support analogous to esp32c3 to esp32s3#5397
[feature] added flash support analogous to esp32c3 to esp32s3#5397Wikwoj0512 wants to merge 1 commit into
Conversation
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Looks reasonable, though I didn't check the modifications to esp32s3.ld. Can someone else also take a look?
| } | ||
|
|
||
| // WriteAt writes the given number of bytes to the block device. | ||
| // Only word (32 bits) length data can be programmed. |
There was a problem hiding this comment.
// Only word (32 bits) length data can be programmed.
Did you check whether this is also true for the ESP32S3? I couldn't easily find it in the SDK: https://docs.espressif.com/projects/esp-idf/en/v6.0.1/esp32s3/api-reference/peripherals/spi_flash/index.html
There was a problem hiding this comment.
Did you check whether this is also true for the ESP32S3? I couldn't easily find it in the SDK: https://docs.espressif.com/projects/esp-idf/en/v6.0.1/esp32s3/api-reference/peripherals/spi_flash/index.html
Yes, this is correct.
| } >IROM | ||
|
|
||
| PROVIDE(__flash_data_start = ALIGN(_irom_end - 0x42000000 + 0x3C000000, 4096)); | ||
| PROVIDE(__flash_data_end = 0x3C000000 + 4M); |
There was a problem hiding this comment.
This would only be correct for devices with 4MB flash. It would be better to do something like we do for rp2040 and allow for specific boards to override this.
|
@Wikwoj0512 thanks for working on this. I made a few comments. Also it would probably be better to only add the specific linker symbols required by this PR to the |
4 participants
No description provided.