Fix WDK7 CMake MSVC version detection#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bundled WDK7 CMake toolchain for CMake 4.3 and CXX-only projects.\n\nCMake can identify WDK7 cl.exe as MSVC 15.0.30729.207 but still enter Windows-MSVC.cmake without CMAKE_CXX_COMPILER_VERSION populated for CXX-only projects, causing:\n\n MSVC compiler version not detected properly\n\nThis explicitly sets the WDK7/VS2008 compiler and MSVC toolset version variables in the toolchain.\n\nValidated locally with a fresh CXX-only WDK7 configure/build/ctest using the modified cmake/wdk7.cmake.