Unified SecretStore for Environment and Keyring resolution#24
Conversation
- Created `SecretStore` to manage credentials with environment -> keyring precedence. - Migrated `GitHubAuth` and `JulesAuth` to use `SecretStore`. - Added headless/CI support by prioritizing `GH_TOKEN`, `GITHUB_TOKEN`, and `JULES_API_KEY`. - Added `IsInteractive()` helper to handle non-TTY environments. - Updated documentation and diagrams to reflect the new auth flow. - Added integration tests for `SecretStore`. Co-authored-by: cdvelop <44058491+cdvelop@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change introduces a unified
SecretStorecomponent that centralizes credential management. It resolves secrets by checking environment variables first and falling back to the system keyring only if necessary. This allowsdevflowtools (gorelease,gopush,codejob) to run in CI/CD and headless environments without user interaction, while maintaining the current interactive experience for local development.Key changes:
secret_store.gowithSecretStoreimplementation and thread-safe lazy keyring initialization.github_auth.goandcodejob_auth.goto use the new store.docs/GORELEASE.md,docs/CODEJOB.md, anddocs/github/diagrams/GITHUB_AUTH_FLOW.mdwith CI/CD usage instructions and updated flow diagrams.test/secret_store_test.goverifying the precedence and lazy initialization logic.PR created automatically by Jules for task 10880722830233109775 started by @cdvelop