Add switchable Dark/Light themes & fix NumPy segmentation fault (#410)#416
Open
l7on3n wants to merge 3 commits into
Open
Add switchable Dark/Light themes & fix NumPy segmentation fault (#410)#416l7on3n wants to merge 3 commits into
l7on3n wants to merge 3 commits into
Conversation
added 3 commits
June 6, 2026 12:23
- Added dynamic theming (Dark/Light/System) support. - Fixed NumPy type handling in audio filters to prevent crashes. - Regenerated filter coefficients and updated UI settings. - Added uv.lock and theme test scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for dynamic theming (Dark/Light/System) across the PyQt and QML interfaces. It also fixes some type handling issues in the audio filter decimation logic that were causing crashes on newer Python/NumPy environments, and introduces
uvfor dependency locking.Theme Changes
QSettings)."Fusion"style for dark mode, building a customQPalette.MainWindowViewModel(window_color,text_color, etc.) that mirror the active PyQt palette.FritureMainWindow.qml,Dock.qml, andControlBar.qmlto bind to the ViewModel palette instead ofSystemPaletteso the QML widgets stay in sync with the main window.Filter / NumPy Fixes
forward,feedback,x_dec,zis) tofloat64inoctave_filter_bank_decimationbefore passing them to Cython (pyx_lfilter) to prevent segfaults.N / 2->N // 2) infilter_design.pyto fixTypeErrorexceptions on newer NumPy versions.generated_filters.pyto match the updated float configs.Development / Infrastructure
uv.lockfor faster local dev usinguv.To Test
TypeErroror segfaulting.Fixes #410 segmentation fault