Skip to content

Conversation

@ic0ns
Copy link
Contributor

@ic0ns ic0ns commented Jun 30, 2025

Summary

  • Removed unused wildcard imports from ModifiableVariableTest.java
  • Refactored BigInteger test exception handling to use modern assertThrows pattern
  • Eliminated static analyzer warnings about unused object allocations

Changes Made

  1. ModifiableVariableTest.java: Removed unused imports for biginteger.*, bytearray.*, and singlebyte.* packages
  2. BigInteger test files: Converted try-catch exception testing pattern to JUnit 5's assertThrows method in:
    • BigIntegerXorModificationTest.java
    • BigIntegerSubtractModificationTest.java
    • BigIntegerExplicitValueModificationTest.java

Test plan

✅ All tests pass (mvn test)
✅ Code formatting applied (mvn spotless:apply)
✅ No compilation errors

- Removed unused wildcard imports from ModifiableVariableTest.java (biginteger, bytearray, singlebyte)
- Refactored BigInteger test exception handling from try-catch to assertThrows pattern
- This modernizes the test code and eliminates static analyzer warnings about unused allocations
@ic0ns ic0ns merged commit 4055efc into main Jun 30, 2025
12 checks passed
@ic0ns ic0ns deleted the fix/unused-code-cleanup branch June 30, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants