fix: TCL-6370 revert login pod to configless-only#34
Open
sagrawal-byte wants to merge 1 commit into
Open
Conversation
The login pod was statically mounting slurm.conf at /etc/slurm/ via the slurm-config ConfigMap, with an initContainer chmod'ing files for mixed permissions. This intercepted srun's config lookup at /etc/slurm/slurm.conf and prevented the configless fallback to /run/slurm/conf/slurm.conf. The static mount also did not include plugstack.conf (which lives in the separate slurm-config-extra ConfigMap), so srun could not find SPANK plugin config -> Pyxis did not load -> --container-image options failed silently. Revert to upstream Slinky's fully-configless login pod design: - /etc/slurm/ contains only slurm.key (the sackd auth key). - sackd fetches slurm.conf, plugstack.conf, etc. via --conf-server into /run/slurm/conf/ at default Slurm mode 0644. - srun's lookup falls through /etc/slurm/slurm.conf (missing) to /run/slurm/conf/slurm.conf, which is readable by LDAP users and has plugstack.conf in the same dir -> Pyxis loads automatically. This also eliminates the original LDAP permission problem that the initContainer chmod dance was solving, because the problematic mixed-permission static mount no longer exists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
TCL-6370 reported that Pyxis stopped loading on v1.0 login pods. Root-cause analysis (see Linear comment):
The Together fork's login-deployment.yaml (introduced in commit
910e26f, 2025-11-23) statically mounts theslurm-configConfigMap at/etc/slurm/, but does not also mountslurm-config-extrawhich holdsplugstack.conf. So/etc/slurm/plugstack.confis missing, and srun's default-path lookup for SPANK config fails.Pre-commit
57c7bdc, srun couldn't read mode-0600 slurm.conf and fell through to/run/slurm/conf/(where plugstack.conf is sitting via sackd's configless distribution) — Pyxis worked accidentally. Once57c7bdcmade slurm.conf successfully readable to non-root users, srun stopped falling through and the latent bug surfaced.How this fixes it
With only
slurm.keyat/etc/slurm/:/etc/slurm/slurm.conf→ missing/run/slurm/conf/slurm.conf(precedence #4b in Slurm's lookup chain)/run/slurm/conf/plugstack.confis there (sackd put it there via configless fetch)--container-imageworksThis also fixes the original LDAP permission problem that
57c7bdcwas solving, because the mixed-permission static mount no longer exists. sackd writes configs to/run/slurm/conf/at default mode 0644, so LDAP users can read them naturally.Test plan
After deploying this change to a v1.0 cluster:
kubectl exec slurm-login-X -- ls -la /etc/slurm/— should show onlyslurm.keykubectl exec slurm-login-X -- ls -la /run/slurm/conf/— should show slurm.conf, plugstack.conf, cgroup.conf, etc.sinfo— should print partitions, not Permission deniedsrun --container-image=ubuntu:24.04 cat /etc/os-release— should print Ubuntu 24.04 (Pyxis loaded)srun hostname— should print the slurmd pod's hostnameRelated
910e26f(created Together's custom login-deployment.yaml)57c7bdc(TCL-4402 split-permissions initContainer)🤖 Generated with Claude Code