-
Notifications
You must be signed in to change notification settings - Fork 0
Inspector client, server 초기 설정 및 배포 파이프라인 추가 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @toothlessdev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 API 변경 사항을 시각적으로 검토할 수 있는 웹 UI 도구인 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이번 Pull Request는 @patchlogr/inspector 클라이언트 및 서버 패키지의 초기 설정을 포함하며, 새로운 .claude/rules 문서와 배포 파이프라인 관련 변경 사항을 추가했습니다. 전반적으로 새로운 모듈의 기반을 잘 마련했지만, 몇 가지 개선 사항이 있습니다. 특히 pre-commit 훅 제거로 인한 코드 품질 관리 방안 재고, NestJS 서버의 TypeScript 설정 강화, 그리고 테스트 커버리지 활성화 등을 고려해볼 수 있습니다. 또한, 문서의 명확성을 높이고 프로젝트 라이선스를 명시하는 것이 좋습니다.
| "description": "", | ||
| "author": "", | ||
| "private": true, | ||
| "license": "UNLICENSED", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "strictNullChecks": false, | ||
| "noImplicitAny": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| include: ["src/**/*.spec.ts"], | ||
| exclude: ["**/dist/**"], | ||
| coverage: { | ||
| enabled: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Results109 tests 109 ✅ 2s ⏱️ Results for commit 9d19f53. |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
📎 Related issues
📦 Scope
📌 Summary
✅ Checklist