Skip to content

PM-4658: restore final deliverables on design drafts#1568

Merged
jmgasper merged 3 commits intodevfrom
PM-4658
Apr 1, 2026
Merged

PM-4658: restore final deliverables on design drafts#1568
jmgasper merged 3 commits intodevfrom
PM-4658

Conversation

@jmgasper
Copy link
Copy Markdown
Collaborator

@jmgasper jmgasper commented Apr 1, 2026

What was broken

  • The work app draft page for design challenges did not render the Final Deliverables editor, so users could not manage the saved file-type metadata after creating a draft.

Root cause

  • The platform-ui challenge editor migration omitted the legacy Final Deliverables control from the Submission Settings section.

What was changed

  • Added a FinalDeliverablesField component that reads and writes the challenge fileTypes metadata.
  • Wired the field into the design challenge Submission Settings section and exported it through the challenge editor component index.
  • Updated the ChallengeEditorPage README to document the restored field.

Any added/updated tests

  • Added FinalDeliverablesField.spec.tsx covering add, duplicate prevention, and remove flows.
  • Updated ChallengeEditorForm.spec.tsx to assert the field renders in Submission Settings for design F2F challenges.

Open with Devin

jmgasper added 2 commits April 1, 2026 22:03
What was broken
The work challenge page no longer showed the billing account id in Advanced Options, so it lost parity with the legacy work-manager challenge view.

Root cause
The platform-ui challenge editor migration preserved billing data for pricing logic, but the read-only Billing Account Id display was not carried over into the new Advanced Options layout.

What was changed
Added a read-only Billing Account Id row back to the work challenge editor Advanced Options and resolved its value from the challenge billing payload with a project billing-account fallback. Added matching styles and updated the challenge editor README.

Any added/updated tests
Added a ChallengeEditorForm regression test that verifies the billing account id renders in Advanced Options when project billing data is available.
What was broken
- The work app draft page for design challenges did not render the Final Deliverables editor, so users could not manage the saved file-type metadata after creating a draft.

Root cause
- The platform-ui challenge editor migration omitted the legacy Final Deliverables control from the Submission Settings section.

What was changed
- Added a FinalDeliverablesField component that reads and writes the challenge `fileTypes` metadata.
- Wired the field into the design challenge Submission Settings section and exported it through the challenge editor component index.
- Updated the ChallengeEditorPage README to document the restored field.

Any added/updated tests
- Added FinalDeliverablesField.spec.tsx covering add, duplicate prevention, and remove flows.
- Updated ChallengeEditorForm.spec.tsx to assert the field renders in Submission Settings for design F2F challenges.
@jmgasper jmgasper requested a review from kkartunov as a code owner April 1, 2026 11:18
devin-ai-integration[bot]

This comment was marked as resolved.

@jmgasper jmgasper merged commit fab65f3 into dev Apr 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant