Conversation
What was broken\nThe Create Engagement page showed the SOFTWARE_DEVELOPER role as Software Engineer instead of Software Developer.\n\nRoot cause\nThe engagement form kept its own hard-coded role label map, and that map used Software Engineer for SOFTWARE_DEVELOPER while the rest of the work app constants used Software Developer.\n\nWhat was changed\nUpdated the engagement form role label mapping to render Software Developer for SOFTWARE_DEVELOPER.\nAdded a focused EngagementEditorForm test that asserts the role dropdown label for SOFTWARE_DEVELOPER.\n\nAny added/updated tests\nUpdated EngagementEditorForm.spec.tsx with coverage for the Software Developer option label.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Create Engagement role dropdown displayed for the role, which did not match the legacy Work Manager wording.
Root cause
maintained its own hard-coded role label map, and that map used for even though the work app constants already used .
What was changed
Updated the engagement form role label mapping so renders as .
Added a focused form test that verifies the dropdown label for .
Any added/updated tests
Updated to cover the corrected role label.