Conversation
What was broken Talent Managers could not see the Engagements tab on the common Work page, and the root all-engagements route still rejected them. Root cause The common-page tab config and route guard only treated admins as eligible for the all-engagements view even though Talent Managers are intended to access engagement management flows. What was changed Added a shared all-engagements access helper for work-app permissions. Updated the common Work tab config and engagements route guard to allow admins and Talent Managers. Updated the route guard message to reflect the supported roles. Any added/updated tests Added tab visibility coverage for Talent Manager versus Project Manager access. Added permission helper coverage for all-engagement access.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Talent Managers could not see the Engagements tab on the common Work page, and the root all-engagements route still rejected them.
Root cause
The common-page tab config and route guard only treated admins as eligible for the all-engagements view even though Talent Managers are intended to access engagement management flows.
What was changed
Added a shared all-engagements access helper for work-app permissions.
Updated the common Work tab config and engagements route guard to allow admins and Talent Managers.
Updated the route guard message to reflect the supported roles.
Any added/updated tests
Added tab visibility coverage for Talent Manager versus Project Manager access.
Added permission helper coverage for all-engagement access.