Conversation
What was broken The Work Manager engagement applications status filter updated its selected value but did not change the rows shown in the table. Root cause The page tracked the selected filter status, but still rendered the full applications list directly instead of applying the selected status to the displayed rows. The engagement header status pill helper also assumed a formatted status string was always present. What was changed Added a memoized filtered applications list and now render the table and empty state from that filtered list. Made the engagement status pill helper tolerant of empty values. Added a regression test that changes the status filter and verifies only matching applications remain visible. Any added/updated tests Added ApplicationsListPage.spec.tsx to cover the status filter behavior.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The Work Manager engagement applications status filter updated its selected value but did not change the rows shown in the table.
Root cause
The page tracked the selected filter status, but still rendered the full applications list directly instead of applying the selected status to the displayed rows.
The engagement header status pill helper also assumed a formatted status string was always present.
What was changed
Added a memoized filtered applications list and now render the table and empty state from that filtered list.
Made the engagement status pill helper tolerant of empty values.
Added a regression test that changes the status filter and verifies only matching applications remain visible.
Any added/updated tests
Added ApplicationsListPage.spec.tsx to cover the status filter behavior.